Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.converter(id) ignores id and uses default one instead #174

Open
GoogleCodeExporter opened this issue Jan 1, 2016 · 1 comment
Open

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Implement ConfigurableMapper in custom class
2. Register multiple convertors for same datatypes with different id's
3. Try using them with method .converter("id")

What is the expected output? What do you see instead?
Converter with provided name should be used, instead the first one defined is 
used

What version of the product are you using? On what operating system?
Issue is present with versions > 1.4.3

Please provide any additional information below.
Test class can be found in an attachment

Original issue reported on code.google.com by [email protected] on 16 Sep 2014 at 3:08

Attachments:

@GoogleCodeExporter
Copy link
Author

The problem is coming from UsedConvertersContext who use the class type for the 
key in the map usedConverters.

To fix the issue, I've created a new method which take in consideration the 
converterId. I've change both Convert and SourceCodeContext to make them use 
that new method. 

See attached class.

Original comment by [email protected] on 15 Oct 2014 at 6:08

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant