Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rehash_on_login not passed to new SessionGuard() #215

Open
MaartenJC opened this issue Feb 3, 2025 · 1 comment
Open

rehash_on_login not passed to new SessionGuard() #215

MaartenJC opened this issue Feb 3, 2025 · 1 comment

Comments

@MaartenJC
Copy link

In Laravel 11 the config 'rehash_on_login' in hashing.php is added. The default is true, but we set it to false.

In the file:
vendor/lab404/laravel-impersonate/src/ImpersonateServiceProvider.php

a new SessuinGuard is contructed, but without the parameter rehashOnLogin. So this defaults to true. it should should pass the config from 'rehash_on_login'.
@pieterschreuder
Copy link

A fix is already proposed in this PR: #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaartenJC @pieterschreuder