Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot test of prometheus metrics #10911

Closed
mhofman opened this issue Jan 29, 2025 · 0 comments · Fixed by #10954
Closed

Add snapshot test of prometheus metrics #10911

mhofman opened this issue Jan 29, 2025 · 0 comments · Fixed by #10954
Assignees
@gibson042
Labels
enhancement New feature or request telemetry

Comments

@mhofman
Copy link
Member

mhofman commented Jan 29, 2025

What is the Problem Being Solved?

We should understand the impact of making changes to our prometheus metrics. While there is various ways to confuse consumers of these, the most obvious one is a change in which metrics are reported. Another is possibly a change in the type or characteristic of the metric

Description of the Design

A snapshot style test, at worse in a3p-integration (but preferably in an ava based required test, like in the cosmic-swingset package), that queries the metrics Prometheus endpoint and snapshots at least the set of metrics exported, and if possible metadata about the characteristics of these metrics.

Security Considerations

None

Scaling Considerations

None

Test Plan

This is a test

Upgrade Considerations

None
@mhofman mhofman added enhancement New feature or request telemetry labels Jan 29, 2025
@gibson042 gibson042 self-assigned this Feb 4, 2025
gibson042 added a commit that referenced this issue Feb 6, 2025
@gibson042
test(cosmic-swingset): Add test coverage for Prometheus output
0676962 
Fixes #10911
@gibson042 gibson042 mentioned this issue Feb 6, 2025
Merged
gibson042 added a commit that referenced this issue Feb 6, 2025
@gibson042
test(cosmic-swingset): Add test coverage for Prometheus output
d115dcd 
Fixes #10911
gibson042 added a commit that referenced this issue Feb 6, 2025
@gibson042
test(cosmic-swingset): Add test coverage for Prometheus output
1572695 
Fixes #10911
This was referenced Feb 7, 2025
Open
Open
gibson042 added a commit that referenced this issue Feb 7, 2025
@gibson042
test(cosmic-swingset): Add test coverage for Prometheus output
16fb6f5 
Fixes #10911
@mergify mergify bot closed this as completed in #10954 Feb 9, 2025
@mergify mergify bot closed this as completed in 736a6c8 Feb 9, 2025
mergify bot added a commit that referenced this issue Feb 9, 2025
@mergify
test(cosmic-swingset): Add test coverage for Prometheus output (#10954)
85bac81 
Extends #10941
Fixes #10911

## Description
Extracts a testable `launchChain` unit in packages/cosmic-swingset/src/chain-main.js, and uses that for an ava snapshot test of localhost:${OTEL_EXPORTER_PROMETHEUS_PORT}/metrics. Includes incidental fixes and utility additions along the way (and therefore best reviewed by commit).

### Security Considerations
None known.

### Scaling Considerations
n/a

### Documentation Considerations
n/a

### Testing Considerations
Just the usual `--update-snapshots` when things change.

### Upgrade Considerations
n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibson042 gibson042

Labels
enhancement New feature or request telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(cosmic-swingset): Add test coverage for Prometheus output Agoric/agoric-sdk
2 participants
@mhofman @gibson042