Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextual slog sender doesn't support phase runs #10924

Open
mhofman opened this issue Jan 31, 2025 · 0 comments
Open

contextual slog sender doesn't support phase runs #10924

mhofman opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mhofman
Copy link
Member

mhofman commented Jan 31, 2025

Describe the bug

Vat termination formalized the concept of run phases, and added a phase attribute to cosmic-swingset-run-* events. It also added a new cleanup phase, that generates potential swingset work but does not create a new "trigger" slog event unlike the inbound or timer triggers.

To Reproduce

Observe slogs on u18, and notice the "run 2" entries have an unknown trigger

Expected behavior

Using the new phase attribute to help classifying the trigger:

  • Right now we assume run=0 is always a leftover phase. In the future we may decide to skip the run altogether if we know there is no work to do. Instead we should only continue / restore a previous trigger info if we're in a leftover phase.
  • For the cleanup phase, correctly populate the trigger type.

Testing consideration

Manual for now. In the future we'll need something like #10365 and the ability to conditionally error when encountering unknown triggers

@mhofman mhofman added the bug Something isn't working label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants