Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings dialog says "Pygments style" #1461

Open
Akuli opened this issue Mar 29, 2024 · 9 comments
Open

settings dialog says "Pygments style" #1461

Akuli opened this issue Mar 29, 2024 · 9 comments

Comments

@Akuli
Copy link
Owner

Akuli commented Mar 29, 2024

screenshot-1711756597

It would be better to say "Color theme for editing" and "Color theme for output of commands". I no longer expect all Porcupine users to know what Pygments is.

@ethical-haquer
Copy link
Contributor

ethical-haquer commented Apr 1, 2024

screenshot-1711756597

It would be better to say "Color theme for editing" and "Color theme for output of commands". I no longer expect all Porcupine users to know what Pygments is.

What about "Theme used for editor", and "Theme used for command output"?

@Moosems
Copy link
Contributor

Moosems commented Apr 2, 2024

You can assign me this :D

@Akuli
Copy link
Owner Author

Akuli commented Apr 2, 2024

"Theme used for editor", and "Theme used for command output"?

Those are far better than "Pygments style", but I think the meaning is the most obvious if we call them "color themes" rather than "themes". Colors are the main thing they do.

@Moosems
Copy link
Contributor

Moosems commented Apr 2, 2024

Looking into this a little more I'm not sure this is a great idea...

    ``pygments_style``: :class:`str`
        Name of the current Pygments style used for syntax highlighting.
        Use this option like this::

            from porcupine import settings
            from pygments import styles
            the_style = styles.get_style_by_name(settings.get('pygments_style', str))

@Akuli
Copy link
Owner Author

Akuli commented Apr 2, 2024

The setting name doesn't need to match what's in UI. The UI needs to be understandable for users, the setting needs to be precise and clear for Porcupine developers.

@Moosems
Copy link
Contributor

Moosems commented Apr 6, 2024

Ok, I'll do this with the settings dialog soon then

@Moosems
Copy link
Contributor

Moosems commented Apr 6, 2024

Mind if I put both in a single PR or would you prefer them separate?

@Akuli
Copy link
Owner Author

Akuli commented Apr 6, 2024

Just make a single PR.

@rdbende
Copy link
Collaborator

rdbende commented Apr 6, 2024

I think you could also make a PR for every character change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants