-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings dialog says "Pygments style" #1461
Comments
You can assign me this :D |
Those are far better than "Pygments style", but I think the meaning is the most obvious if we call them "color themes" rather than "themes". Colors are the main thing they do. |
Looking into this a little more I'm not sure this is a great idea...
|
The setting name doesn't need to match what's in UI. The UI needs to be understandable for users, the setting needs to be precise and clear for Porcupine developers. |
Ok, I'll do this with the settings dialog soon then |
Mind if I put both in a single PR or would you prefer them separate? |
Just make a single PR. |
I think you could also make a PR for every character change. |
It would be better to say "Color theme for editing" and "Color theme for output of commands". I no longer expect all Porcupine users to know what Pygments is.
The text was updated successfully, but these errors were encountered: