Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grb::set matrix-to-matrix broken in mixed-domain #241

Closed
byjtew opened this issue Aug 30, 2023 · 2 comments · Fixed by #290
Closed

grb::set matrix-to-matrix broken in mixed-domain #241

byjtew opened this issue Aug 30, 2023 · 2 comments · Fixed by #290
Assignees
@byjtew
Labels
bug Something isn't working
Milestone
v0.8

Comments

@byjtew
Copy link
Collaborator

byjtew commented Aug 30, 2023

The primitive grb::set( Matrix<D>&, const Matrix<T> ) contains a bug related to the cast of the values from T to D.
@byjtew byjtew added the bug Something isn't working label Aug 30, 2023
@byjtew byjtew self-assigned this Aug 30, 2023
This was referenced Aug 9, 2023
Closed
Closed
@byjtew byjtew linked a pull request Aug 30, 2023 that will close this issue
654 grb::set matrix-to-matrix broken in mixed-domain #242
Closed
@byjtew byjtew changed the title grb::set matrix-to-matrix broken in mixed-domain" grb::set matrix-to-matrix broken in mixed-domain Aug 31, 2023
@anyzelman anyzelman added this to the v0.8 milestone Jan 29, 2024
@anyzelman
Copy link
Member

Hi @byjtew -- I don't recall we merged into develop, but #654 does say it is merged-- what happened here?

@byjtew byjtew mentioned this issue Feb 5, 2024
Merged
@byjtew byjtew removed a link to a pull request Feb 5, 2024
654 grb::set matrix-to-matrix broken in mixed-domain #242
Closed
@byjtew
Copy link
Collaborator Author

byjtew commented Feb 5, 2024

Hi @byjtew -- I don't recall we merged into develop, but #654 does say it is merged-- what happened here?

I am pretty sure I force-pushed incorrectly and erased my commits. I managed to find a previous version, it's in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byjtew byjtew

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

654 grb::set matrix to matrix broken in mixed domain Algebraic-Programming/ALP
2 participants
@byjtew @anyzelman