Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis function with oor DAScale value still triggers error message from DC_Configure #2349

Open
t-b opened this issue Feb 11, 2025 · 0 comments
Labels

Comments

@t-b
Copy link
Collaborator

t-b commented Feb 11, 2025

FTP: pr-2302\AdaptiveSupraPXPs01282025\H25.03.302.11.53.01.03.pxp

That experiment has

 (PSQ_DAScale) The DAScale value could not be set as it is out-of-range.
  Please adjust the "External Command Sensitivity" in the MultiClamp Commander application and try again.
  Some values in DataWave exceed device limits for DATA_ACQUISITION mode (channel index 0, position 32768). Maybe the DA scale needs adjustment?
  Some values in DataWave exceed device limits for DATA_ACQUISITION mode (channel index 0, position 27753). Maybe the DA scale needs adjustment?

so we got an out of range error in Adaptive, but then got the exceed device limits message.

A short test with

diff --git a/Packages/tests/HardwareAnalysisFunctions/UTF_PatchSeqDAScale_Adapt.ipf b/Packages/tests/HardwareAnalysisFunctions/UTF_PatchSeqDAScale_Adapt.ipf
index fe09145fd..13eff5044 100644
--- a/Packages/tests/HardwareAnalysisFunctions/UTF_PatchSeqDAScale_Adapt.ipf
+++ b/Packages/tests/HardwareAnalysisFunctions/UTF_PatchSeqDAScale_Adapt.ipf
@@ -3040,6 +3040,11 @@ static Function PS_DS_AD19_preAcq(string device)

     SetAsyncChannelProperties(device, asyncChannels, -1e6, +1e6)

+    PGC_SetAndActivateControl(device, "IndexEnd_DA_00", str = "PSQ_DaScale_Sub_DA_0")
+    PGC_SetAndActivateControl(device, "Check_DataAcq_Indexing", val = 1)
+
+    AFH_AddAnalysisParameter("PSQ_DaScale_Sub_DA_0", "AsyncQCChannels", wv = asyncChannels)
+
     WAVE/Z overrideResults = GetOverrideResults()
     CHECK_WAVE(overrideResults, NUMERIC_WAVE)
     JWN_SetWaveInWaveNote(overrideResults, "PassingRheobaseSweep", {5})

and runwithopts(testcase = "PS_DS_AD19") could not reproduce the problem.

@t-b t-b added Analysis Functions bug Something isn't working DA_Ephys labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant