Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow with FAILED status #37

Open
alexei-led opened this issue Nov 5, 2017 · 3 comments
Open

Workflow with FAILED status #37

alexei-led opened this issue Nov 5, 2017 · 3 comments
Labels
enhancement

Comments

@alexei-led
Copy link
Contributor

Currently, Workflow can have one of two possible statuses:

  1. WorkflowComplete - when all its steps are completed
  2. WorkflowFailed - when "Deadline" is exceeded

IMHO, it should be failed also when one of workflow steps fails (Job fails).
@sdminonne
Copy link
Contributor

Yeah, in general, I concur. Problem is what are we going to do when a Job failed?

  1. Should we implement a retry policy? I think we should.
  2. When a job failed should we stop all the workflow? I think we should
  3. Remove the all the workflows? I think we should not.

Thoughts?
@clamoriniere1A: ideas?

@alexei-led
Copy link
Contributor Author

@sdminonne when Job fail, after backoffLimit retries, we can stop the Workflow (if a user wants to, by specifying some tag).
And I think we should not remove the failed workflow, user can do it later if wants to. Keeping workflow generated jobs/pods will allow inspecting "Failure" and maybe "fixing" workflow for next run.

@sdminonne
Copy link
Contributor

@alexei-led agree. Need to put together a proposal for the tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexei-led @sdminonne