Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization: API client should only send requests if an account is connected #9883

Open
marcinbot opened this issue Dec 5, 2024 · 0 comments · May be fixed by #10304
Open

Optimization: API client should only send requests if an account is connected #9883

marcinbot opened this issue Dec 5, 2024 · 0 comments · May be fixed by #10304
Assignees
@dpaun1985
Labels
category: core WC Payments core related issues, where it’s obvious. category: engineering For product engineering, architecture work, tech debt and so on. focus: account lifecycle priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: enhancement The issue is a request for an enhancement.

Comments

@marcinbot
Copy link
Contributor

With the exception of onboarding and account fetch, the WC_Payments_API_Client should prevent the request from going out if the account is not connected.

Suggested in #9716 (comment)
@marcinbot marcinbot added category: core WC Payments core related issues, where it’s obvious. category: engineering For product engineering, architecture work, tech debt and so on. labels Dec 5, 2024
@marcinbot marcinbot mentioned this issue Dec 5, 2024
Closed
@vbelolapotkov vbelolapotkov added focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). type: enhancement The issue is a request for an enhancement. labels Dec 6, 2024
@vbelolapotkov vbelolapotkov added focus: account lifecycle and removed focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). labels Dec 24, 2024
@vladolaru vladolaru added the priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability label Jan 21, 2025
@dpaun1985 dpaun1985 self-assigned this Jan 31, 2025
@dpaun1985 dpaun1985 linked a pull request Feb 5, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpaun1985 dpaun1985

Labels
category: core WC Payments core related issues, where it’s obvious. category: engineering For product engineering, architecture work, tech debt and so on. focus: account lifecycle priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict API requests if the account is not connected Automattic/woocommerce-payments
4 participants
@marcinbot @vbelolapotkov @vladolaru @dpaun1985