Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenized ECE not able to parse selected variation w/ "Variation Swatches for WooCommerce" #10303

Closed
frosso opened this issue Feb 5, 2025 · 2 comments · Fixed by #10306
Closed

Tokenized ECE not able to parse selected variation w/ "Variation Swatches for WooCommerce" #10303

frosso opened this issue Feb 5, 2025 · 2 comments · Fixed by #10306
Assignees
@frosso
Labels
component: checkout Issues related to Checkout focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Milestone
WooPayments 9.0.0

Comments

@frosso
Copy link
Contributor

frosso commented Feb 5, 2025 •
edited
Loading

Describe the bug

Internally reported here: p1738743947909059/1738707211.859139-slack-CGGCLBN58

The "Variation Swatches for WooCommerce" plugin alters the site's markup for the variations, causing the ECE to not be able to parse the selected variation on a product page.

This causes a Store API add-to-cart call made with incorrect values causing it to fail with woocommerce_rest_variation_id_from_variation_data, preventing the product from being able to check out within the scope of the ECE dialog.

Image

The product can still be added to the cart via the "Add to cart" button.

ECE on cart & checkout pages remains unaffected.

To Reproduce

  • Install the plugin
  • Ensure you have GooglePay/ApplePay enabled
  • Click on the GooglePay/ApplePay button
  • Observe the add-to-cart call result

Actual behavior

Screenshots

Expected behavior

Product pages using "Variation Swatches for WooCommerce" can still add the product to the cart.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context
@frosso frosso added the type: bug The issue is a confirmed bug. label Feb 5, 2025
@frosso frosso self-assigned this Feb 6, 2025
@frosso frosso mentioned this issue Feb 6, 2025
Merged
6 tasks
@frosso
Copy link
Contributor Author

frosso commented Feb 7, 2025

Related to woocommerce/woocommerce#45844 & woocommerce/woocommerce#47792

@frosso
Copy link
Contributor Author

frosso commented Feb 11, 2025

I created this change in WC Core to adjust the Store API so it can support the same attribute names that are rendere on the product page: woocommerce/woocommerce#55317

I'll look into further refining how we can support both API versions, while we wait for the PR to get approved and integrated in WC Core.

@FangedParakeet FangedParakeet added this to the WooPayments 9.0.0 milestone Feb 11, 2025
@pierorocca pierorocca added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frosso frosso

Labels
component: checkout Issues related to Checkout focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
WooPayments 9.0.0
Development

Successfully merging a pull request may close this issue.

fix: attribute selection from PDPs with tokenized ECE Automattic/woocommerce-payments
4 participants
@frosso @FangedParakeet @eduardoumpierre @pierorocca