Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSE: infinite scroll not working #61202

Open
vindl opened this issue Feb 17, 2022 · 3 comments
Open

FSE: infinite scroll not working #61202

vindl opened this issue Feb 17, 2022 · 3 comments
Labels
[Goal] Full Site Editing [Pri] Normal Schedule for the next available opportuinity. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@vindl
Copy link
Member

vindl commented Feb 17, 2022

User wants to use the Infinite Scrolling feature on the blog post. Turned it on in settings but it doesn't work. I read that a widget in the Footer could stop this from working. There is no widget in footer (FSE), but it is still not loading. Removing the whole footer doesn't help. Any thoughts on how could this be achieved? Is this supported in FSE. Thank you!

cc @csabarakasz

p1645051036945269-slack-C01DF571R5Y
@vindl vindl added [Type] Bug When a feature is broken and / or not performing as intended [Goal] Full Site Editing labels Feb 17, 2022
@jeyip
Copy link
Contributor

jeyip commented Mar 1, 2022 •
edited
Loading

I did some investigation. Infinite scrolling for posts ( link ) is a toggle that is available for universal and block themes. I verified availability for Bennett and Twenty Twenty Two on dotcom simple sites.

Screen Shot 2022-02-28 at 11 38 36 PM

After looking at the source code in the themes repo, however, I don't see logic or tags in either theme to indicate support for this feature. @scruffian, @ianstewart, @kjellr should we disable this feature setting for our FSE themes?

@kjellr
Copy link
Contributor

kjellr commented Mar 1, 2022

For now, yes I think we probably need to hide this. Related issue here: Automattic/jetpack#21787

@jeyip jeyip mentioned this issue Mar 2, 2022
Closed
@jeyip jeyip self-assigned this Mar 2, 2022
@jeyip jeyip removed their assignment Apr 3, 2023
@jeyip
Copy link
Contributor

jeyip commented Apr 3, 2023

#61624 (comment)

@cuemarie cuemarie added the [Pri] Normal Schedule for the next available opportuinity. label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Goal] Full Site Editing [Pri] Normal Schedule for the next available opportuinity. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vindl @kjellr @jeyip @cuemarie