Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image name "bridgetokubernetes.azurecr.io/lpkremoteagent:1.3.4" is hardcoded, breaks in hardened environments #355

Open
sleepy-manul opened this issue Jan 25, 2024 · 1 comment
Labels
bug Something isn't working waiting for response Waiting for a response by the original author of the ticket

Comments

@sleepy-manul
Copy link

Describe the bug
The extension assumes that the Kubernetes cluster can access the container registry bridgetokubernetes.azurecr.io, which is an absolute no-go in corporate environments. The name of the registry where the image is pulled from must therefore be configurable.

Mention the platform you are using
Visual Studio 2022 Community, Extension Version 3.2.20240123.7

To Reproduce
self-explanatory

Expected behavior
The profile for Bridge-to-Kubernetes has a configuration option to set the container registry and choose a pull secret.

Screenshots
not required

Logs:
not applicable

Desktop (please complete the following information):
not applicable

Smartphone (please complete the following information):
not applicable

Additional context
not applicable

@sleepy-manul sleepy-manul added the bug Something isn't working label Jan 25, 2024
@hsubramanianaks
Copy link
Collaborator

hsubramanianaks commented Jan 25, 2024

@sleepy-manul there is an option to provide your registry as environment variable. if these variables are present as part of your environment variable it should pick your custom registry. Please let me know for further details. Thank you.

Env variables are:
BRIDGE_DEVHOSTIMAGENAME
BRIDGE_RESTORATIONJOBIMAGENAME
BRIDGE_ROUTINGMANAGERIMAGENAME

ex: export BRIDGE_DEVHOSTIMAGNAME='registryurl/tag'

@hsubramanianaks hsubramanianaks added the waiting for response Waiting for a response by the original author of the ticket label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting for response Waiting for a response by the original author of the ticket
Projects
None yet
Development

No branches or pull requests

2 participants