Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fundamentals] PR build does not fail on formatting errors #3136

Open
jennyf19 opened this issue Feb 14, 2025 · 0 comments
Open

[Fundamentals] PR build does not fail on formatting errors #3136

jennyf19 opened this issue Feb 14, 2025 · 0 comments
Labels
Fundamentals Internal Indicates issue was opened by the IdentityModel team Reduce dev toil

Comments

@jennyf19
Copy link
Collaborator

The PR build does not fail on formatting errors, allowing those to go through, but then it fails other PRs which did not impact that code. These issues should be caught as early as possibler (ideally in the IDE without having to re-build everything) and definitely in the PR build.

example: #3135

Image
@jennyf19 jennyf19 added Fundamentals Internal Indicates issue was opened by the IdentityModel team Reduce dev toil labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fundamentals Internal Indicates issue was opened by the IdentityModel team Reduce dev toil
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jennyf19