Trigger metadata refresh for token decryption errors #3149
+91
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
jennyf19
approved these changes
Feb 26, 2025
GeoK
reviewed
Feb 26, 2025
| @@ -252,7 +252,8 @@ internal static bool IsRecoverableException(Exception exception) | |||
| { | |||
| return exception is SecurityTokenInvalidSignatureException | |||
| || exception is SecurityTokenInvalidIssuerException | |||
| || exception is SecurityTokenSignatureKeyNotFoundException; | |||
| || exception is SecurityTokenSignatureKeyNotFoundException | |||
| || exception is SecurityTokenDecryptionFailedException; | |||
There was a problem hiding this comment.
I don't think that this is sufficient. We should signal metadata refresh only if encryption keys are part of metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3148
This pull request includes several changes to improve the handling of token decryption errors and enhance the test cases for token validation. The most important changes include modifications to the
IsRecoverableExceptionandIsRecoverableExceptionTypemethods, updates to the test cases for token decryption, and the addition of new test cases to handle retry logic for token decryption.Enhancements to token decryption error handling:
src/Microsoft.IdentityModel.Tokens/TokenUtilities.cs: AddedSecurityTokenDecryptionFailedExceptionto the list of recoverable exceptions in bothIsRecoverableExceptionandIsRecoverableExceptionTypemethods. [1] [2]Updates to test cases for token decryption:
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Decryption.cs: RefactoredValidateTokenAsyncDecryptionTheoryDatato include a new test caseJWE_TokenDecryptError_SuccessOnRetry, which tests the retry logic for token decryption errors. [1] [2] [3] [4]Addition of new test cases:
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandlerTests.cs: Added a new test caseJWE_TokenDecryptError_SuccessOnRetrytoValidateJweTestCasesto validate the retry logic for token decryption errors using a configuration manager. [1] [2]