Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] IdentityComparer.AreEqual(object object1, object object2) #3130

Open
pmaytak opened this issue Feb 13, 2025 · 0 comments · May be fixed by #3151
Open

[Internal] IdentityComparer.AreEqual(object object1, object object2) #3130

pmaytak opened this issue Feb 13, 2025 · 0 comments · May be fixed by #3151
Labels
Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team

Comments

@pmaytak
Copy link
Contributor

pmaytak commented Feb 13, 2025

IdentityComparer.AreEqual(object object1, object object2) (without CompareContext) doesn't throw if objects don't match, but only returns a bool. There are usages of this where we don't assert the return value, and thus the test method can succeed when it should've failed.

TODO:

  • Look though all the cases where this method overload is used and probably replace it with the overload that accepts the CompareContext and remove this overload.
  • If it's not possible to remove this overload (there's some valid reason for this to be used), then make sure the result is always asserted.
@pmaytak pmaytak added Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team labels Feb 13, 2025
omidmloo added a commit to omidmloo/azure-activedirectory-identitymodel-extensions-for-dotnet that referenced this issue Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
1 participant