Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to avoid HTTP calls in app creation #856

Open
Avery-Dunn opened this issue Aug 23, 2024 · 0 comments
Open

Refactor to avoid HTTP calls in app creation #856

Avery-Dunn opened this issue Aug 23, 2024 · 0 comments
Labels
confidential-client For issues related to confidential client apps public-client For questions/issues related to public client apps SDK-Consistency Items that deal with consistency between all MSALs

Comments

@Avery-Dunn
Copy link
Collaborator

As pointed out in this comment on the PR adding custom authority support, it is a bad practice to make HTTP calls during app creation. If there is no internet connection, then a program that creates an app on startup can confusingly fail before it actually tries to use MSAL for anything.

Unfortunately, unlike similar calls the sort of information this HTTP call provides doesn't only happen in one place after app creation: it's needed for token calls, certificate helpers, URL builders, and more, all of which are public APIs that can be called in any order.

Some refactoring is needed to ensure that no HTTP calls occur during app creation, and that the HTTP calls are made in a way that doesn't lead to missing info/null pointers/etc.

@Avery-Dunn Avery-Dunn added SDK-Consistency Items that deal with consistency between all MSALs public-client For questions/issues related to public client apps confidential-client For issues related to confidential client apps labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confidential-client For issues related to confidential client apps public-client For questions/issues related to public client apps SDK-Consistency Items that deal with consistency between all MSALs
Projects
None yet
Development

No branches or pull requests

1 participant