Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authority should be optional when providing azureCloudOptions + tenant #7591

Open
timtucker-dte opened this issue Feb 25, 2025 · 0 comments
Open
Labels
confidential-client Issues regarding ConfidentialClientApplications feature-unconfirmed msal-node Related to msal-node package Needs: Attention 👋 Awaiting response from the MSAL.js team question Customer is asking for a clarification, use case or information.

Comments

@timtucker-dte
Copy link

timtucker-dte commented Feb 25, 2025

Core Library

MSAL Node (@azure/msal-node)

Wrapper Library

Not Applicable

Public or Confidential Client?

Confidential

Description

When azureCloudOptions and tenant are both set, authority (and known authorities) should be optional & determined automatically.

Currently, authority just remains set to the default of:
https://login.microsoftonline.com/common

Setting:

{
    azureCloudOptions: {
        azureCloudInstance: AzureCloudInstance.AzurePublic,
        tenant: '(tenant id)'
    }
}

Should have the same result as:

{
    authority: `${AzureCloudInstance.AzurePublic}/(tenant id)`,
    knownAuthorities: [`${AzureCloudInstance.AzurePublic}/(tenant id)`],
    azureCloudOptions: {
        azureCloudInstance: AzureCloudInstance.AzurePublic,
        tenant: '(tenant id)'
    }
}
@timtucker-dte timtucker-dte added feature-unconfirmed question Customer is asking for a clarification, use case or information. labels Feb 25, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Feb 25, 2025
@github-actions github-actions bot added msal-node Related to msal-node package public-client Issues regarding PublicClientApplications confidential-client Issues regarding ConfidentialClientApplications and removed public-client Issues regarding PublicClientApplications labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confidential-client Issues regarding ConfidentialClientApplications feature-unconfirmed msal-node Related to msal-node package Needs: Attention 👋 Awaiting response from the MSAL.js team question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

1 participant