From 7254705524221df1bb791fe5b031d39b7ad011e5 Mon Sep 17 00:00:00 2001 From: Tomas Valent Date: Thu, 5 Jan 2017 22:55:19 +0000 Subject: [PATCH 1/2] devisefix --- lib/omniauth/strategies/azure_activedirectory.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/omniauth/strategies/azure_activedirectory.rb b/lib/omniauth/strategies/azure_activedirectory.rb index 20339c5..dbf540b 100644 --- a/lib/omniauth/strategies/azure_activedirectory.rb +++ b/lib/omniauth/strategies/azure_activedirectory.rb @@ -325,5 +325,3 @@ def verify_options end end end - -OmniAuth.config.add_camelization 'azure_activedirectory', 'AzureActiveDirectory' From 4fe20c2b5503ab071122be79d60b0cf46ae6ec86 Mon Sep 17 00:00:00 2001 From: Tomas Valent Date: Thu, 5 Jan 2017 23:09:09 +0000 Subject: [PATCH 2/2] rename classes and modules to represent Ruby conventions --- lib/omniauth/azure_activedirectory/version.rb | 2 +- lib/omniauth/strategies/azure_activedirectory.rb | 4 ++-- omniauth-azure-activedirectory.gemspec | 2 +- spec/omniauth/strategies/azure_activedirectory_spec.rb | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/omniauth/azure_activedirectory/version.rb b/lib/omniauth/azure_activedirectory/version.rb index b007acd..24a6844 100644 --- a/lib/omniauth/azure_activedirectory/version.rb +++ b/lib/omniauth/azure_activedirectory/version.rb @@ -22,7 +22,7 @@ module OmniAuth # The release version. - module AzureActiveDirectory + module AzureActivedirectory VERSION = '1.0.0' end end diff --git a/lib/omniauth/strategies/azure_activedirectory.rb b/lib/omniauth/strategies/azure_activedirectory.rb index dbf540b..085d5b2 100644 --- a/lib/omniauth/strategies/azure_activedirectory.rb +++ b/lib/omniauth/strategies/azure_activedirectory.rb @@ -28,8 +28,8 @@ module OmniAuth module Strategies # A strategy for authentication against Azure Active Directory. - class AzureActiveDirectory - include OmniAuth::AzureActiveDirectory + class AzureActivedirectory + include OmniAuth::AzureActivedirectory include OmniAuth::Strategy class OAuthError < StandardError; end diff --git a/omniauth-azure-activedirectory.gemspec b/omniauth-azure-activedirectory.gemspec index 5fd46ad..a4ec2a7 100644 --- a/omniauth-azure-activedirectory.gemspec +++ b/omniauth-azure-activedirectory.gemspec @@ -3,7 +3,7 @@ require 'omniauth/azure_activedirectory/version' Gem::Specification.new do |s| s.name = 'omniauth-azure-activedirectory' - s.version = OmniAuth::AzureActiveDirectory::VERSION + s.version = OmniAuth::AzureActivedirectory::VERSION s.author = 'Microsoft Corporation' s.email = 'nugetaad@microsoft.com' s.summary = 'Azure Active Directory strategy for OmniAuth' diff --git a/spec/omniauth/strategies/azure_activedirectory_spec.rb b/spec/omniauth/strategies/azure_activedirectory_spec.rb index dbdc791..ac6bd81 100644 --- a/spec/omniauth/strategies/azure_activedirectory_spec.rb +++ b/spec/omniauth/strategies/azure_activedirectory_spec.rb @@ -25,7 +25,7 @@ # This was fairly awkward to test. I've stubbed every endpoint and am simulating # the state of the request. Especially large strings are stored in fixtures. -describe OmniAuth::Strategies::AzureActiveDirectory do +describe OmniAuth::Strategies::AzureActivedirectory do let(:app) { -> _ { [200, {}, ['Hello world.']] } } let(:x5c) { File.read(File.expand_path('../../../fixtures/x5c.txt', __FILE__)) }