Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkpoint files smaller #3

Open
pfebrer opened this issue Jun 26, 2023 · 3 comments
Open

Make checkpoint files smaller #3

pfebrer opened this issue Jun 26, 2023 · 3 comments

Comments

@pfebrer
Copy link
Collaborator

pfebrer commented Jun 26, 2023

Checkpoint files currently are much larger than needed because they contain huge arrays for the EquivariantProductBasisBlock modules, which could be recomputed instead of stored.

@peterbjorgensen
Copy link
Collaborator

The most robust way would be to modify this line of mace
https://github.com/ACEsuit/mace/blob/44b6da4a5edaa4c3ef867a11728555403d1d475d/mace/modules/symmetric_contraction.py#L110
with the keyword persistent=False to avoid saving the U matrices in the state dict.

Otherwise we would need to hack it something like this https://discuss.pytorch.org/t/how-to-customize-the-module-state-dict-load-state-dict/139604/2

I can try to make a pull request for mace. I can't see any benefit of saving the U matrices for them either.

@pfebrer
Copy link
Collaborator Author

pfebrer commented Jun 27, 2023

I can't see any benefit of saving the U matrices for them either.

Ok, then I think it makes sense to propose a change upstream!

@pfebrer
Copy link
Collaborator Author

pfebrer commented Jun 28, 2023

I submitted an issue: ACEsuit/mace#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants