-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat needs an ability to attach images/files #1617
Comments
ImplementationBackend (2):
App (4):
Be notice:the current chat feature: ensure the new chat works seamlessly with the current chat feature. keep the UI simple: we can use openai app as the standard product. thread and end-thread option: the best implementation is we could detect if users are asking a question that needs the context from file(what file) or not. btw, if it's too complicated at this time, so let's go with either:
|
|
@mdmohsin7 man, pls read this ticket's description and feel free to ask me anything. if everything is clear and you're excited about this feature, drop your UI/UX proposal then go ahead. @nquang29 said that he is also excited with this ticket so you can ask him if he can help on backend side or not / Quang's Discord @windtran_ |
Got it! As mentioned we can simply follow the UX of ChatGPT or even iMessage
What if we upload the file right after the user selects it? Similar to how the ChatGPT app does it So if I understand correctly, @nquang29 will be working on the backend and I'll have to make the app side changes? |
yes i mean uploading right after selecting the image / file. use our figma and draft the design pls sir you can do both, or just ask Quang to see if he could help so that we can speed up the progress. |
The designs in our figma are very old and are not the ones that are being followed currently. I'll quickly code the design without the functionality and will share the image with you Alright I'll message Quang on discord |
Are we going to allow multiple file uploads? |
multiple file uploads - yes at the time you use figma, your mind focuses completely on design (ui/ux) - not code. that's the reason why if you want to create great ux, you need to draft your ideas somewhere - away from your code editor. |
What is the max limit on the number of files? And also any max limit on the file size? Since we don't have the current UI designs in Figma, it would have taken more time to design the new UI so I just went with code itself for now. Pls check the video in #1629, that should give you an idea of how the UI will look. The app side part is almost done (will have to modify it a bit to support multiple files), just need to connect to the backend |
just follow what chatgpt did |
ChatGPT only allows 3-4 files on free plan I've asked Quang on discord for help with backend, he's interested it seems and waiting for him response |
Implementation
(Thinh's note)
Backend (2):
new
api routePOST /files
to upload files, input: file, logic: create new docs users>uid>files{id, name, thumbnail, mime_type, openai_file_id}
direct upload to openai(/files), output: {id, name, thumbnail,}POST /messages
with new body paramfile_ids: [str]
, logic: chat with files use openai https://platform.openai.com/docs/api-reference/threads , use the best openai model o1 (or gpt-4o if o1 is not work with file yet)App (4):
/files
, before submitting messages/messages
with the new body fieldfile_ids
Be notice:
the current chat feature: ensure the new chat works seamlessly with the current chat feature.
keep the UI simple: we can use openai app as the standard product.
thread and end-thread option: the best implementation is we could detect if users are asking a question that needs the context from file(what file) or not. btw, if it's too complicated at this time, so let's go with either:
Maybe useful
The text was updated successfully, but these errors were encountered: