Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in with Google/appple #1769

Closed
kodjima33 opened this issue Feb 8, 2025 · 17 comments · Fixed by #1781
Closed

Sign in with Google/appple #1769

kodjima33 opened this issue Feb 8, 2025 · 17 comments · Fixed by #1781

Comments

@kodjima33
Copy link
Collaborator

kodjima33 commented Feb 8, 2025

Login with Apple/google

Some people who use iPhones don't have Apple accounts to sign in. They want to
Be able to sign in with Google

@chakri-chax
Copy link

Hey there @kodjima33
I wanted to work on this issue
I have good oauth implementation knowledge.

@mdmohsin7
Copy link
Collaborator

@chakri-chax we don’t assign or lock bounties to anyone unless they have previously had a PR merged into our repository. If no one is working on an issue, feel free to drop a comment, start working on it, and open a PR.

@ibrahimnd2000
Copy link

I am working on it.

@ibrahimnd2000
Copy link

Just created a PR for this

@joshijoe05
Copy link
Contributor

/attempt #1769

I have reviewed the codebase and noticed that the sign-in buttons come from different packages, resulting in inconsistencies in their appearance. To maintain a uniform look and avoid dependency on multiple packages, it would be better to create custom buttons that follow a consistent design without affecting the existing code structure

@ibrahimnd2000
Copy link

/attempt #1769

I have reviewed the codebase and noticed that the sign-in buttons come from different packages, resulting in inconsistencies in their appearance. To maintain a uniform look and avoid dependency on multiple packages, it would be better to create custom buttons that follow a consistent design without affecting the existing code structure

I addressed this here, it now uses single dependency (sign_in_button) for both of the buttons.

@andrewgazelka
Copy link

@addbounty $100

@addbounty
Copy link

addbounty commented Feb 11, 2025

banner
button

Make a Draft PR early so others can see you are working on it! To automatically create one:

# Using npx (installed if you have NodeJS/npm)
npx bountybot start BasedHardware/omi#1769

# Or, use cargo (installed if you have Rust)
cargo install bounty
bounty start BasedHardware/omi#1769

When merged, you will receive the bounty!

ibrahimnd2000 added a commit to ibrahimnd2000/omi that referenced this issue Feb 11, 2025
joshijoe05 added a commit to joshijoe05/omi that referenced this issue Feb 11, 2025
beastoin added a commit that referenced this issue Feb 15, 2025
/claim #1769 
Fixes : #1769 

This PR enables iOS users to log in via Google along with Apple Sign-In.
It also introduces custom reusable widgets for the UI (Sign-In Buttons)
, reducing dependency on external packages and making the app more
self-reliant.
@beastoin beastoin moved this from Done to In review in omi TODO / bounties Feb 17, 2025
@beastoin
Copy link
Collaborator

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-02-16.at.22.01.29.mp4

@kodjima33
Copy link
Collaborator Author

@joshijoe05 can you fix?

@beastoin why did we merge without testing it on a branch first

@kodjima33 kodjima33 moved this from In review to In progress in omi TODO / bounties Feb 18, 2025
@beastoin
Copy link
Collaborator

fixed it already. bro, we had tested it before merging. but the issue is not happened during testing, it's happened on the production build and is related to the obfuscation.

@kodjima33

@joshijoe05
Copy link
Contributor

fixed it already. bro, we had tested it before merging. but the issue is not happened during testing, it's happened on the production build and is related to the obfuscation.

@kodjima33

So is everything alright now @beastoin ?

@beastoin
Copy link
Collaborator

yes /

@joshijoe05 have you try the latest testflight / internal test ver ? and, let me know the good/bad/ugly things. feel free to dm me to get the access.

@joshijoe05
Copy link
Contributor

yes /

@joshijoe05 have you try the latest testflight / internal test ver ? and, let me know the good/bad/ugly things. feel free to dm me to get the access.

Can you send me an invite to this mail ?, will test the new build
Mail : [email protected]

@beastoin
Copy link
Collaborator

invitation sent, pls accept it then lmk @joshijoe05

@beastoin beastoin moved this from In progress to In review in omi TODO / bounties Feb 24, 2025
@joshijoe05
Copy link
Contributor

invitation sent, pls accept it then lmk @joshijoe05

I was assigned a Customer Support role, which does not have the necessary permissions to test the latest TestFlight version of the app.

@mdmohsin7
Copy link
Collaborator

@joshijoe05 I've invited you to the internal TestFlight group. Please check your email—you should be receiving an invite soon

@kodjima33 kodjima33 moved this from In review to Done in omi TODO / bounties Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants