Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What regex variant is supported #122

Open
kweb- opened this issue Oct 14, 2022 · 3 comments
Open

What regex variant is supported #122

kweb- opened this issue Oct 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kweb-
Copy link

kweb- commented Oct 14, 2022

This really isn't a bug report or at least I don't think that it is so sorry for using the bug report to ask the following:
What regex variant is supported in this update? I've tried experimenting with the regex feature but I haven't had any luck. For example, the following regex should match in several tabs that I have open but it does not.

re:Ki[cC]ad

This should match Kicad or KiCad

I'm either not entering the expression correctly or I'm not using features that are supported but I've tried other basic expressions with no luck.

@Bill13579
Copy link
Owner

Bill13579 commented Oct 16, 2022

Hey @kweb-!

Tabby uses fancy-regex, which is Rustlang flavour Regex with Lookahead/Lookbehind added in, most regex features should be there.

Try re:/Ki[cC]ad/m, the regex search requires the slashes before and after and the multiline flag

@kweb-
Copy link
Author

kweb- commented Oct 17, 2022

Hi - thanks for the reply!
Here are some samples with a baseline search using the term kicad and then your suggested regex term for comparison:

Baseline:
Here's some search results with just kicad as the search term:
TabbyRegex1
You can see that there are results with "KiCad" and "KICAD" in the page titles.

Here are the results using the regex search term re:/Ki[cC]ad/m:
TabbyRegex2

If my testing criteria are correct, there is only one tab from the baseline search set that the regex shouldn't have matched and that's the one with "KiCAD".

Another test used https for the baseline search and re:/https/m for the regex search and the latter returns far fewer results than are picked up with the former.

When using regex search terms, is the content searched limited in some way?

I hope this helps.

@Bill13579 Bill13579 self-assigned this Oct 17, 2022
@Bill13579 Bill13579 added the bug Something isn't working label Oct 17, 2022
@Bill13579
Copy link
Owner

Bill13579 commented Oct 23, 2022

Hey @kweb-, I've had some time to look into this more, I think the issue was with Single Page Webapps (YouTube and Google) and indexing not running for them. I have a dev build that have the search fixed, could you test it out and make sure it's working? https://github.com/Bill13579/tabby/actions/runs/3308468621
(There are instructions for how to load the dev build on the README page)
Note: the indexing will only run if the page is first loaded because of content scripts, so it's best to start out in a blank session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants