Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eFP (tissue) views colouring and heat scale do not align with ePlant2 #144

Open
VinLau opened this issue Nov 7, 2024 · 2 comments
Open
Assignees

Comments

@VinLau
Copy link
Collaborator

VinLau commented Nov 7, 2024

The eFP views seem to have incorrect colouring where the colouring of tissues is based on the group maxima/minima versus the global (i.e. entire view) maxima values. This makes it such that the colouring is very different to (current) ePlant2.

To reproduce/see on ePlant2:

  1. Go to https://bar.utoronto.ca/eplant
  2. Enter a gene such as ABI3
  3. Go to the Tissue & Experiment Viewer
  4. Explore some views and look at their values, along the colour scale (see below):

image

Note the current view on ePlant in development for the same gene (ABI3):

image

Note that the value of '21.53' is the same on the tooltip however the colouring is vastly different. It should be closer to yellow than red as the maximum for the view is 120.64. Also the SD is slightly off.

The bottom-left heat scale is off.

We will need to refactor how the getColor function (svg.tsx) works and/or potentially how to parses the XML to include global maximum.

@VinLau VinLau self-assigned this Nov 7, 2024
@VinLau
Copy link
Collaborator Author

VinLau commented Nov 7, 2024

I can use the min/max (need to refactor?) inside getInitialData inside index.tsx of EFP (

max: Math.max(...groupsData.map((g) => g.max)),
) to grab the view-global maximum for colouring.

@mwkyuen
Copy link
Collaborator

mwkyuen commented Nov 28, 2024

I wonder if this is a similar issue w.r.t. colours: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants