Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Open RFP] ( $800 ) - Basic USD/Z export ( Mesh, materials w/ PBR support ) #2

Open
br-matt opened this issue Nov 26, 2022 · 10 comments
Assignees
Labels
In Progress Bounty In Progress

Comments

@br-matt
Copy link
Contributor

br-matt commented Nov 26, 2022

requirements

  • Mesh exported as USD can be loaded into Unreal Editor with Meshes and Materials showing up correctly. PBR Material exported correctly as well.

  • Mesh exported as USDZ can be viewed in AR using iOS built in viewer. Meshes and Materials showing up correctly with PBR or not.

  • Documentation in the BJS Docs somewhere

recommended approach

None

Notes

Skeletons, Lights, Node Materials and many other things USD supports are out of scope for this first version

@br-matt br-matt changed the title [Open Bounty] ( $800 ) - Basic USDZ export [Open Bounty] ( $800 ) - Basic USDZ export ( Mesh, materials w/ PBR support ) Nov 26, 2022
@br-matt br-matt changed the title [Open Bounty] ( $800 ) - Basic USDZ export ( Mesh, materials w/ PBR support ) [Open RFP] ( $800 ) - Basic USDZ export ( Mesh, materials w/ PBR support ) Nov 26, 2022
@br-matt br-matt changed the title [Open RFP] ( $800 ) - Basic USDZ export ( Mesh, materials w/ PBR support ) [Open RFP] ( $800 ) - Basic USD/Z export ( Mesh, materials w/ PBR support ) Dec 5, 2022
@lokiiarora
Copy link

I would like to take this up :) !
Would a good start be from porting it from Three.js here

@br-matt
Copy link
Contributor Author

br-matt commented Feb 16, 2023

Hey thanks! That seems like a reasonable start to me. Maybe some of the BJS folks will chime in otherwise though @sebavan

@br-matt br-matt assigned br-matt and lokiiarora and unassigned br-matt Feb 16, 2023
@br-matt br-matt added In Progress Bounty In Progress and removed Unclaimed labels Feb 16, 2023
@sebavan
Copy link
Collaborator

sebavan commented Feb 16, 2023

Seems reasonable to me as well !!! let's see if @bghgary approves the idea ???

@bghgary
Copy link

bghgary commented Feb 17, 2023

I don't see why this won't work.

@br-matt
Copy link
Contributor Author

br-matt commented Feb 27, 2023

Hey @lokiiarora just checking in and wondering how this was going ?

@lokiiarora
Copy link

Hey @br-matt , working on it, I've got to the point where I can export a USDZ file with all textures, geometries and zip working fine.
Haven't specifically gotten the scene file .usda working as such

@br-matt
Copy link
Contributor Author

br-matt commented May 5, 2023

Hey @lokiiarora guessing some things came up. Is it alright if I move this back to Ready status or are you still able to finish it? Not a big deal but want to open it up for someone else in case you became busy

@br-matt br-matt added Unclaimed and removed In Progress Bounty In Progress labels May 19, 2023
@Pryme8
Copy link

Pryme8 commented May 26, 2023

https://github.com/Pryme8/USDZExport/blob/main/src/exporter/exporter.ts

So Ive got this to the point where it will load nearly the same as the Three.js export.

There are a few TODOs but those are probably out of scope for the initial commit.

One thing that I could use some help with is why some geometry is not loading on the viewer even though the underlying buffers are the same on both exports from Three.js and our export. Not sure how that works but yeah....

Also don't want to spend a ton of time on this as the bounty would then become not cost effective for my time.

image
Ours is on the left, Three.js is on the right.

Pretty sure the color difference is the normal texture being in sRGB space instead of raw. That is on the list of TODOs that needs to be fixed.

@br-matt br-matt added In Progress Bounty In Progress and removed Unclaimed labels May 26, 2023
@br-matt br-matt assigned Pryme8 and unassigned lokiiarora May 26, 2023
@br-matt
Copy link
Contributor Author

br-matt commented May 26, 2023

Wow awesome @Pryme8 :) thanks for picking this up instead. @sebavan what do you think maybe forums is best place or here for assistance ?

@sebavan
Copy link
Collaborator

sebavan commented Jun 5, 2023

Yup the PR is up so we can discuss on the PR on the forum. @bghgary and @Popov72 will do a first PR pass there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress Bounty In Progress
Projects
None yet
Development

No branches or pull requests

5 participants