-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playRtl change swap arrows? #526
Comments
Hmm, I though the plugin did swap the functions of the buttons internally, but you can always do this yourself easily using any of the these three methods to actually swap the arrows: 1 ) use CSS to swap the locations of the arrows.
|
i tried the easiest way (for me), with the .css |
on chrome the arrows appear to fade in, on firefox the right arrow just pops out, while the left one has a sliding in animation but from outside of the slider instead from the inside :/ |
Can you please modify this demo so I can see the code you're using and hopefully help resolve this issue :) |
sorry, im not sure how to save the changes so you could see them.
if its uncomfortable i can upload the file somewhere. |
To save your changes in that demo, just click "Update" at the top. No need to register, login or signup or anything. I added the default settings you shared to this demo and everything seems to work fine for me. Maybe if you changed the theme to the default, then compare it to the original you will notice that the navigation order is also reversed. Is this what you mean? Also when you compare the original (non-RTL) demo, you'll see that pressing the left arrow moves the slides to the right. But when the |
thats the problem. then it shouldn't be reversed. |
Then I would suggest not using the .anythingSlider .anythingWindow {
direction: ltr;
unicode-bidi: bidi-override;
} |
already included it ^^ |
Sure that shouldn't be a problem. But I wonder if I should just remove that option completely? The slideshow is also reversed, should it not switch either? |
my opinion on the matter is that arrows are signs that everyone, regardless of their culture interpret the same way. only the direction of the autoPlay should be changed. am i sound crazy? |
i just noticed that with autoPlayLocked it continues to rotate video slide even if video is played. |
Hmm, don't you mean the opposite? I was just testing this and it seems that when |
i have and yet when i play the video it still slides away in the middle. autoPlayLocked says playing a video =/= user changing slides. its a common sense that if i clicked 'play' on the video i don't want it to slide away while i watch it. but i do want it to resume with the automatic sliding as the video is done playing. that what i was trying to achieve. |
Hmm, |
i tried with a youtube video enclosed with iframe and tested both with chrome and firefox. |
Are you seeing any console errors? Chrome is being really picky when I try to test using dropbox and it's throwing errors for me. |
when i hit the play button on the video i got this
|
on firefox i don't get anything new (there are errors on loading) when i press the play button, but it slides away anyway :/ |
thanks for the update. what about the video sliding away while playing if autoPlayLocked is set? |
Get The |
What does the .min stands for? |
The The |
good news is the arrows are fixed ! RTL is more tricky then i thought. as i see it RTL means only the sliding effect change sides. |
Sorry, I thought I had tested it... I was in a hurry to get that next version out and didn't get a chance to test everything. I really need to add unit tests! Anyway, I'll try to get this fixed soon. With the video, it should be working. Are you initializing the video extension? It changed in v1.9: $(function(){
$('#slider')
.anythingSlider()
// initialize the video extension, as desired (new v1.9)
.anythingSliderVideo({
// video id prefix; suffix from $.fn.anythingSliderVideo.videoIndex
videoId : 'asvideo',
// this option replaces the `addWmodeToObject` option in the main plugin
wmode : "opaque",
// auto load YouTube api script
youtubeAutoLoad : true,
// YouTube iframe parameters, for a full list see:
// https://developers.google.com/youtube/player_parameters#Parameters
youtubeParams : {
modestbranding : 1,
iv_load_policy : 3,
fs : 1,
wmode: 'opaque' // this is set by the wmode option above, so no need to include it here
}
});
}); |
my bad, i didn't look through the changelog. |
what do you think about RTL feed? i mean showing the slides in reverse order. |
Do you mean while the slideshow is playing? Edit: Wouldn't that be like having the What do you think of this demo? It's basically as if I made the |
do you mean the reversed index numbers? no, that not what i meant. playReverse might be a good feature, but thats not how i understand RTL (right to left =/= reversed) or with short conditions |
Sorry, I meant for you to start the slideshow in that demo. The panels are set to float right, so the order is reversed, but when the slideshow plays, it still goes from slide 1 to slide 5. I see what you mean by starting from the last panel, using |
you got me wrong. i only suggested that you might want to add a feature that will play the panels in reverse order, but playRTL should not play it in reverse. |
Hi @3Necromancer! Honestly, the way AnythingSlider has set up Thanks! |
the arrows are correct now. there are two 'issues' remaining:
under RTL should play (just like playRTL: false): img1 -> img2 -> img3 -> img4 -> img5 -> img1 -> etc..
you do a great job! |
i think that when playRtl is used, the forward and backward arrow functions should be swapped as well. Because when you click the left arrow which supposed to be forward/next it brings back the previous slide.
not sure how to do it right now, guess only possible with making an HTML elements and appending the function to it?
The text was updated successfully, but these errors were encountered: