Problem generating client when using NodaTime types in the schema.

[david-driscoll]

Product

Strawberry Shake

Version

15.0.3

Link to minimal reproduction

https://github.com/david-driscoll/gql-duplicatekey-poc

Steps to reproduce

I've created a reproduction repository, with a simple project and a simplified.

A simple clone and dotnet build will give you an error like this:

What is expected?

Build should succeed.

What is actually happening?

Build fails.

Relevant log output

Restore complete (0.1s)
  gql-duplicatekey-poc failed with 2 error(s) (0.2s)
    EXEC : error GQL: An item with the same key has already been added. Key: LocalDate
    /Users/david/.nuget/packages/strawberryshake.server/15.0.3/build/StrawberryShake.Server.targets(71,5): error MSB3073: The command "dotnet "/Users/david/.nuget/packages/strawberryshake.server/15.0.3/build/../tools/net9/dotnet-graphql.dll" generate "/Users/david/Development/david-driscoll/gql-duplicatekey-poc" -o "/Users/david/Development/david-driscoll/gql-duplicatekey-poc/obj/Debug/net9.0/berry" -n gql_duplicatekey_poc -a md5 -t" exited with code 1.

Build failed with 2 error(s) in 0.6s

Additional context

Now curiously if I comment out all the usages of LocalDate, LocalTime and LocalDateTime the project builds.

You can see the diff here for the successful build: david-driscoll/gql-duplicatekey-poc@a3ef895

The working branch is: https://github.com/david-driscoll/gql-duplicatekey-poc/tree/working
The failing branch is: https://github.com/david-driscoll/gql-duplicatekey-poc/tree/master

I tried debugging to no avail, I don't know whats going on, lol. Input or output it doesn't appear to matter.

I was able to narrow down the issue appears to be TypeRegistrar.GetUnhandled() returning the duplicate types from the dependencies. How or why, I could not tell you.

[glen-84]

@david-driscoll Can you please try 15.1.0-p.3?

[michaelstaib]

@david-driscoll any feedback?

[Dontrym3]

I think i have the same issue in my api, here's my partial stacktrace:

HotChocolate.SchemaException: For more details look at the `Errors` property.

1. An item with the same key has already been added. Key: LocalDate

   at HotChocolate.Configuration.TypeInitializer.DiscoverTypes()
   at HotChocolate.Configuration.TypeInitializer.Initialize()
   at HotChocolate.SchemaBuilder.Setup.InitializeTypes(SchemaBuilder builder, IDescriptorContext context, IReadOnlyList`1 types)
   at HotChocolate.SchemaBuilder.Setup.Create(SchemaBuilder builder, LazySchema lazySchema, IDescriptorContext context)
   at HotChocolate.SchemaBuilder.Create(IDescriptorContext context)
   at HotChocolate.SchemaBuilder.HotChocolate.ISchemaBuilder.Create(IDescriptorContext context)
   at HotChocolate.Execution.RequestExecutorResolver.CreateSchemaAsync(ConfigurationContext context, RequestExecutorSetup setup, RequestExecutorOptions executorOptions, IServiceProvider schemaServices, TypeModuleChangeMonitor typeModuleChangeMonitor, CancellationToken cancellationToken)

i've tried to use version: 15.1.0-p.3 without success.

Like @david-driscoll, if I remove my LocalDate Property it works.

Here's a small example on how i locally reproduce the issue:

public class Query
{
    // this crash, I must comment for the sdl to successfully generate
    public List<Failure> GetFailure()
        => [new Failure() { Name = "yo", Date = LocalDate.MinIsoValue }];

    public List<Success> GetSuccess()
        => [new Success() { Name = "yo" }];
}

public class Failure
{
    public string Name { get; set; }
    public LocalDate Date { get; set; }
}

public class Success
{
    public string Name { get; set; }
}

i'm using the HotChocolate.Types.NodaTime package right now but I believe even before it was causing problem without the package (I was always using NodaTime LocalDate type in my domain)

[josteinkjerstad]

+1 to this. We do not use NodaTime but still have the same issue

[glen-84]

@josteinkjerstad Do you have your own type named LocalDate, LocalTime, or LocalDateTime?

[josteinkjerstad]

@glen-84 No we dont

It seems like this happened after the scalar in schema.graphql changed from Date to LocalDate when upgrading to v15.

Our frontend handles this just fine but its our test projects in c# that fails. If I manually remove the scalar definition for LocalDate in the schema.graphql it all works just fine. It seems like the LocalDate has been moved to the Types namespace in v15 - could it be that our test project is trying to "generate" the LocalDate definition from both a) Types and b) the scalar definition defined in the schema.graphql and hence the duplicate key?

Heres a screenshot of what happened to our schema.graphql file in terms of scalars after updating to V15

[glen-84]

@Dontrym3

The error should be:

The name LocalDate was already registered by another type.

(fixed in #8058)

To fix this, you need to reference HotChocolate.Types.NodaTime, and use .AddType<LocalDateType>();, as documented.

@josteinkjerstad

I'm not able to reproduce your issue, and it's not the same as the original issue here, which relates to Strawberry Shake.

Please open a new issue.

@david-driscoll

I'll close this issue now, as I believe that it should be resolved in the latest preview releases.