[Bug] cargo install error :reference to packed field is unaligned

[lost22git]

Checklist

• I've looked through troubleshooting, known problems, and existing open issues for similar issues.

Describe the issue

cargo install error msg

error[E0793]: reference to packed field is unaligned
*tick_count.QuadPart_mut() = read_volatile(&(*USER_SHARED_DATA).u.TickCountQuad);
     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
     = help: copy the field contents to a local variable, or replace the reference with a raw pointer and use `read_unaligned`/`write_unaligned` (loads and stores via `*p` must be properly aligned even when using raw pointers)
error: could not compile `ntapi` due to 2 previous errors

What operating system and version are you using?

win11

What architecture are you using?

x86_64 / AMD64

What terminal(s) are you running bottom on?

windows terminal

What version of bottom are you running?

latest

How did you install bottom?

cargo

How can we reproduce this?

cargo install bottom

Additional information

No response

[ClementTsang]

Hmmm, interesting. What version of Rust are you using? I'm guessing it might be due to some warning that's been upgraded to an error in recent versions of Rust.

EDIT: Yeah, I think it's this. If I build on 1.67:

warning: the following packages contain code that will be rejected by a future version of Rust: ntapi v0.3.7
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`

Relevant upstream issue: MSxDOS/ntapi#15

[ClementTsang]

I guess for now a workaround is using the pre-built binaries? There's a winget package and MSI installer.

[ClementTsang]

Ah. Are you using nightly or beta? I can run cargo install bottom fine on stable (1.68), though I definitely do need to fix this/find workarounds for the future.

[lost22git]

@ClementTsang it works after switching to stable channel, thanks ;-)

[ClementTsang]

Glad it worked out for you!

---

Just as an extra update (mostly for myself), this is already fixed in the current master branch, as we only rely on ntapi 0.4.0, which reports no issues when I try checking with beta/nightly (cargo +beta check). Trying this with 0.8.0, which uses 0.3.7, causes the errors above.

I'll likely do a 0.8.1/0.9.0 update within the next few weeks, maybe after #812.