Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move terminal velocity jacobian out of implicit diffusion #3511

Closed
szy21 opened this issue Jan 4, 2025 · 1 comment
Closed

Move terminal velocity jacobian out of implicit diffusion #3511

szy21 opened this issue Jan 4, 2025 · 1 comment
Assignees
@trontrytel
Labels
ASAP Issue has high priority

Comments

@szy21
Copy link
Member

szy21 commented Jan 4, 2025

Currently, the terminal velocity jacobian is added only when implicit_diffusion is true here. We need to change to always add it when using terminal velocity. This is needed for running moist baroclinic wave with 1M microphysics for the dycore paper (as moist baroclinic wave doesn't have vertical diffusion). @trontrytel Could you take this on? Dennis can help if needed.
@szy21 szy21 added the ASAP Issue has high priority label Jan 4, 2025
@trontrytel trontrytel self-assigned this Jan 6, 2025
@trontrytel trontrytel mentioned this issue Jan 6, 2025
Closed
@szy21
Copy link
Member Author

szy21 commented Jan 17, 2025

This should be fixed by #3521

@szy21 szy21 closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trontrytel trontrytel

Labels
ASAP Issue has high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trontrytel @szy21