From 734f744dca65ea60a9a76a7f9c42d5bab7dce549 Mon Sep 17 00:00:00 2001
From: Cloudzp <rocsfly@163.com>
Date: Sun, 7 Apr 2024 18:20:07 +0800
Subject: [PATCH] fix issues #898

---
 .../recommendation_rule_controller.go         | 51 ++++++++++++++++++-
 1 file changed, 50 insertions(+), 1 deletion(-)

diff --git a/pkg/controller/recommendation/recommendation_rule_controller.go b/pkg/controller/recommendation/recommendation_rule_controller.go
index fa8ec55b4..6a4365d93 100644
--- a/pkg/controller/recommendation/recommendation_rule_controller.go
+++ b/pkg/controller/recommendation/recommendation_rule_controller.go
@@ -41,6 +41,54 @@ import (
 	"github.com/gocrane/crane/pkg/utils"
 )
 
+type ObjectKey struct {
+	Namespace   string
+	APIVersion  string
+	Kind        string
+	Name        string
+	Recommender string
+}
+
+type RecommendationIndex struct {
+	mtx sync.RWMutex
+	idx map[ObjectKey]*analysisv1alph1.Recommendation
+}
+
+func NewRecommendationIndex(recommendations analysisv1alph1.RecommendationList) *RecommendationIndex {
+	idx := make(map[ObjectKey]*analysisv1alph1.Recommendation, len(recommendations.Items))
+	for i := range recommendations.Items {
+		r := &recommendations.Items[i]
+		idx[createIndexKey(r)] = r
+	}
+
+	return &RecommendationIndex{
+		idx: idx,
+	}
+}
+
+func createIndexKey(r *analysisv1alph1.Recommendation) ObjectKey {
+	return ObjectKey{
+		Kind:        r.Spec.TargetRef.Kind,
+		APIVersion:  r.Spec.TargetRef.APIVersion,
+		Namespace:   r.Spec.TargetRef.Namespace,
+		Name:        r.Spec.TargetRef.Name,
+		Recommender: string(r.Spec.Type),
+	}
+}
+
+func (idx *RecommendationIndex) GetRecommendation(id ObjectIdentity) *analysisv1alph1.Recommendation {
+	key := ObjectKey{
+		Kind:        id.Kind,
+		APIVersion:  id.APIVersion,
+		Namespace:   id.Namespace,
+		Name:        id.Name,
+		Recommender: id.Recommender,
+	}
+	idx.mtx.RLock()
+	defer idx.mtx.RUnlock()
+	return idx.idx[key]
+}
+
 type RecommendationRuleController struct {
 	client.Client
 	Scheme          *runtime.Scheme
@@ -147,9 +195,10 @@ func (c *RecommendationRuleController) doReconcile(ctx context.Context, recommen
 		keys = append(keys, k)
 	}
 	sort.Strings(keys) // sort key to get a certain order
+	recommendationIndex := NewRecommendationIndex(currRecommendations)
 	for _, key := range keys {
 		id := identities[key]
-		id.Recommendation = GetRecommendationFromIdentity(identities[key], currRecommendations)
+		id.Recommendation = recommendationIndex.GetRecommendation(id)
 		identitiesArray = append(identitiesArray, id)
 	}