Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualDomain: New resource attribute "start_scripts" #856

Closed
berlevdv opened this issue Oct 10, 2016 · 1 comment
Closed

VirtualDomain: New resource attribute "start_scripts" #856

berlevdv opened this issue Oct 10, 2016 · 1 comment

Comments

@berlevdv
Copy link
Contributor

berlevdv commented Oct 10, 2016

Hello, dear developers and administrators!

I use VirtualDomain in a cluster of virtual machines. Recently there was a corruption of data due to a rather old version of VirtualDomain that comes with Centos 7 epel-release repo. In this version of VirtualDomain function "VirtualDomain_Validate_All()" call everytime when VirtualDomain script executes. When domain definition files (attr "config") were unavailable, VirtualDomain found that the virtual machine is not running ("Configuration file $OCF_RESKEY_config not readable, resource considered stopped."), but that was not true, and start this VM's on another node. Then I got corruption of data, because multiple instances of VM with shared storage was launched. In master branch of VirtualDomain this bug is absent, but from now I want to control if the virtual machine is running somewhere more before domain start. In my opinion the VirtualDomain does not include this functionality, as well as a set of usecases can be used. I propose to introduce a new attribute "start_scripts" for the domain launch control. After that, the administrator will be able to implement the required functionality through scripts.

I'm new in github, please see my pull request #857 and if necessary, add the "start_scripts" attribute to master branch.

@krig
Copy link
Contributor

krig commented Nov 15, 2016

Closing as #857 exists for this issue.

@krig krig closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants