From 23d0b531accca6523a102a9729ce06e4da34f7f5 Mon Sep 17 00:00:00 2001 From: leanwit Date: Thu, 26 Nov 2020 22:12:54 -0300 Subject: [PATCH] [csharp] [booking] Remove unused imports and fix variable name in test --- .../csharp-booking-01_base/src/Booking/BookingId.cs | 4 +--- .../csharp-booking-01_base/src/Booking/CustomerName.cs | 4 +--- .../test/Booking.Tests/BookingShould.cs | 8 ++++---- .../src/Booking/BookingId.cs | 4 +--- .../src/Booking/CustomerName.cs | 4 +--- .../src/Booking/DateRange.cs | 4 ---- .../src/Booking/Discount.cs | 8 +------- .../test/Booking.Tests/BookingShould.cs | 8 ++++---- .../src/Booking/BookingId.cs | 4 +--- .../src/Booking/CustomerName.cs | 4 +--- .../src/Booking/DateRange.cs | 4 ---- .../src/Booking/Discount.cs | 8 +------- .../test/Booking.Tests/BookingShould.cs | 8 ++++---- .../src/Booking/BookingId.cs | 5 +---- .../src/Booking/CustomerName.cs | 5 +---- .../src/Booking/Discount.cs | 8 +------- .../test/Booking.Tests/BookingShould.cs | 8 ++++---- 17 files changed, 27 insertions(+), 71 deletions(-) diff --git a/examples/csharp/csharp-booking-01_base/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-01_base/src/Booking/BookingId.cs index cb435e13..568cff9a 100644 --- a/examples/csharp/csharp-booking-01_base/src/Booking/BookingId.cs +++ b/examples/csharp/csharp-booking-01_base/src/Booking/BookingId.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class BookingId { diff --git a/examples/csharp/csharp-booking-01_base/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-01_base/src/Booking/CustomerName.cs index c09aa084..ebe00e6d 100644 --- a/examples/csharp/csharp-booking-01_base/src/Booking/CustomerName.cs +++ b/examples/csharp/csharp-booking-01_base/src/Booking/CustomerName.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class CustomerName { diff --git a/examples/csharp/csharp-booking-01_base/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-01_base/test/Booking.Tests/BookingShould.cs index 97d60f6d..6b484c12 100644 --- a/examples/csharp/csharp-booking-01_base/test/Booking.Tests/BookingShould.cs +++ b/examples/csharp/csharp-booking-01_base/test/Booking.Tests/BookingShould.cs @@ -33,7 +33,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet() [Fact] private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() { - var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0); + var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -52,13 +52,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() new TaxValue(0) ); - Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking)); } [Fact] private void GetTheCorrectStatusWhenTheBookingIsFinished() { - var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0); + var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -77,7 +77,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished() new TaxValue(0) ); - Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds)); } } } diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/BookingId.cs index cb435e13..568cff9a 100644 --- a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/BookingId.cs +++ b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/BookingId.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class BookingId { diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/CustomerName.cs index c09aa084..ebe00e6d 100644 --- a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/CustomerName.cs +++ b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/CustomerName.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class CustomerName { diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/DateRange.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/DateRange.cs index 2bd0bf3b..efe9d2b4 100644 --- a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/DateRange.cs +++ b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/DateRange.cs @@ -1,8 +1,4 @@ using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; namespace CodelyTv.Booking { diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/Discount.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/Discount.cs index 83227abb..e47d891e 100644 --- a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/Discount.cs +++ b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/Discount.cs @@ -1,10 +1,4 @@ -using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class Discount { diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/test/Booking.Tests/BookingShould.cs index 021e2f86..e8706b08 100644 --- a/examples/csharp/csharp-booking-02_introduce_parameter_object/test/Booking.Tests/BookingShould.cs +++ b/examples/csharp/csharp-booking-02_introduce_parameter_object/test/Booking.Tests/BookingShould.cs @@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet() [Fact] private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() { - var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0); + var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() new Tax(TaxType.NONE, new TaxValue(0)) ); - Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking)); } [Fact] private void GetTheCorrectStatusWhenTheBookingIsFinished() { - var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0); + var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished() new Tax(TaxType.NONE, new TaxValue(0)) ); - Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds)); } } } diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/BookingId.cs index cb435e13..568cff9a 100644 --- a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/BookingId.cs +++ b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/BookingId.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class BookingId { diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/CustomerName.cs index c09aa084..ebe00e6d 100644 --- a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/CustomerName.cs +++ b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/CustomerName.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class CustomerName { diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/DateRange.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/DateRange.cs index 2bd0bf3b..efe9d2b4 100644 --- a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/DateRange.cs +++ b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/DateRange.cs @@ -1,8 +1,4 @@ using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; namespace CodelyTv.Booking { diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/Discount.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/Discount.cs index 83227abb..e47d891e 100644 --- a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/Discount.cs +++ b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/Discount.cs @@ -1,10 +1,4 @@ -using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class Discount { diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/test/Booking.Tests/BookingShould.cs index 021e2f86..e8706b08 100644 --- a/examples/csharp/csharp-booking-03_preserve_whole_object/test/Booking.Tests/BookingShould.cs +++ b/examples/csharp/csharp-booking-03_preserve_whole_object/test/Booking.Tests/BookingShould.cs @@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet() [Fact] private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() { - var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0); + var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() new Tax(TaxType.NONE, new TaxValue(0)) ); - Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking)); } [Fact] private void GetTheCorrectStatusWhenTheBookingIsFinished() { - var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0); + var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished() new Tax(TaxType.NONE, new TaxValue(0)) ); - Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds)); } } } diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/BookingId.cs index cb435e13..00983a2d 100644 --- a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/BookingId.cs +++ b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/BookingId.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class BookingId { @@ -8,5 +6,4 @@ public sealed class BookingId public BookingId(string value) => this.value = value; } - } diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/CustomerName.cs index c09aa084..54a0b158 100644 --- a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/CustomerName.cs +++ b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/CustomerName.cs @@ -1,6 +1,4 @@ -using System; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class CustomerName { @@ -8,5 +6,4 @@ public sealed class CustomerName public CustomerName(string value) => this.value = value; } - } diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/Discount.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/Discount.cs index 85ec2d04..37d965c1 100644 --- a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/Discount.cs +++ b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/Discount.cs @@ -1,10 +1,4 @@ -using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; - -namespace CodelyTv.Booking +namespace CodelyTv.Booking { public sealed class Discount { diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/test/Booking.Tests/BookingShould.cs index 021e2f86..e8706b08 100644 --- a/examples/csharp/csharp-booking-04_tell_dont_ask/test/Booking.Tests/BookingShould.cs +++ b/examples/csharp/csharp-booking-04_tell_dont_ask/test/Booking.Tests/BookingShould.cs @@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet() [Fact] private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() { - var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0); + var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive() new Tax(TaxType.NONE, new TaxValue(0)) ); - Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking)); } [Fact] private void GetTheCorrectStatusWhenTheBookingIsFinished() { - var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0); + var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0); var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0); var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0); @@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished() new Tax(TaxType.NONE, new TaxValue(0)) ); - Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted)); + Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds)); } } }