Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Windows Setup.exe is Codesigned #37

Closed
robinjhuang opened this issue Sep 19, 2024 · 1 comment · Fixed by #43
Closed

Verify Windows Setup.exe is Codesigned #37

robinjhuang opened this issue Sep 19, 2024 · 1 comment · Fixed by #43
Assignees
@KenCorma

Comments

@robinjhuang
Copy link
Member

ComfyUI-0.0.9 Setup.exe

Currently when I run the release GI action, the resulting download is not code signed because Windows Defender gives me a warning. The ComfyUI zip file is code signed though. So might just be a pathing issue.
@KenCorma KenCorma linked a pull request Sep 21, 2024 that will close this issue
Fixed Windows Auto-Update #43
Merged
@KenCorma
Copy link
Collaborator

New logic in Build Win App Action can be removed after this PR is pushed to main.
electron/windows-sign#19

The issue is that Digicert will not accept sha1 as a valid signature type so we can only sign with Sha256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KenCorma KenCorma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Windows Auto-Update Comfy-Org/desktop
2 participants
@robinjhuang @KenCorma