Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add ThumbnailImageSource and OnBuffering Properties #1749

Open
5 of 8 tasks
PrathamsGithub opened this issue Mar 13, 2024 · 2 comments
Open
5 of 8 tasks

[Proposal] Add ThumbnailImageSource and OnBuffering Properties #1749

PrathamsGithub opened this issue Mar 13, 2024 · 2 comments
Labels
blocked new proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail

Comments

@PrathamsGithub
Copy link

PrathamsGithub commented Mar 13, 2024

Feature name

Add ThumbnailImageSource and OnBuffering Properties

Link to discussion

#1749

Progress tracker

  • Android Implementation
  • iOS Implementation
  • MacCatalyst Implementation
  • Windows Implementation
  • Tizen Implementation
  • Unit Tests
  • Samples
  • Documentation

Summary

This proposal if for adding two properties:

  1. "ThumbnailImageSource" This property can be use to show thumbnail image when video is not loaded.
  2. "OnBuffering" This Property will be an event which will trigger when the video is buffering. Using this we can show/hide activity indicator when this event triggers.

Motivation

This can improve the user experience and enhance the video rendering

Detailed Design

public class MediaElement
{

public static readonly BindableProperty ThumbnailImageSourceProperty;
public static readonly BindableProperty OnBufferingProperty;

public ImageSource ThumbnailImage
{
    get ;
    set ;
}

public EventHandler<CurrentState> OnBuffering
{
    get ;
    set ;
}

}

Usage Syntax

<toolkit:MediaElement 
Source="https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4"
ShouldShowPlaybackControls="True"
ThumbnailImageSource="Bunny.png"
OnBuffering="MediaElement_OnBuffering" />

Drawbacks

No response

Alternatives

No response

Unresolved Questions

No response

Tasks

Preview Give feedback
No tasks being tracked yet.
@PrathamsGithub PrathamsGithub added new proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail labels Mar 13, 2024
@TheCodeTraveler
Copy link
Collaborator

Hi @PrathamsGithub!

This Proposal is missing two things before we can move forward:

  1. The Link to Discussion points to a Discussion on Disposing MediaElement. Please correct this link to point to your Discussion on ThumbnailImageSource
  2. Detailed Design needs to include code and show the API Design. See other Proposals, like RatingView, for examples.

@PrathamsGithub
Copy link
Author

Hi @PrathamsGithub!

This Proposal is missing two things before we can move forward:

  1. The Link to Discussion points to a Discussion on Disposing MediaElement. Please correct this link to point to your Discussion on ThumbnailImageSource
  2. Detailed Design needs to include code and show the API Design. See other Proposals, like RatingView, for examples.

Thanks for helping me. I didn't found any discussion regarding this proposal. So, I added this as Link to Discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked new proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail
Projects
None yet
Development

No branches or pull requests

2 participants