Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent GOSSIP_MAX_SIZE usage in GossipSub #8957

Open
Nashatyrev opened this issue Dec 26, 2024 · 0 comments
Open

Inconsistent GOSSIP_MAX_SIZE usage in GossipSub #8957

Nashatyrev opened this issue Dec 26, 2024 · 0 comments

Comments

@Nashatyrev
Copy link
Contributor

Description

Teku is computing compressedMaxGossipSize based on uncompressed GOSSIP_MAX_SIZE and then passes it to Libp2p Gossip builder as a maxGossipMessageSize parameter.

However GossipRouter assumes this size as the overall gRPC message size, i.e. including all publish messages and control GossipSub messages.

This doesn't look like a security issue as there are no means to construct a valid gossip message of the compressedMaxGossipSize. Thus there is no ways to induce any kind of temporary network splits which may potentially happen when one client implementation refuses a valid gossip message while others propagate it.

This spec PR clarifies message size limits. The PR implementation should resolve this issue, so it probably makes sense to leave this issue until the PR is merged.

Versions

  • Software version: current master version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant