Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub authored-commit validation logging #2796

Open
joanagmaia opened this issue Feb 5, 2025 — with Linear · 0 comments
Open

Fix GitHub authored-commit validation logging #2796

joanagmaia opened this issue Feb 5, 2025 — with Linear · 0 comments

Comments

Copy link
Contributor

https://app.datadoghq.com/logs?query=cluster_name:cm-prod-oracle%20status:error%20@msg:%22You%20need%20to%20use%20github%20authored%20commit%20activity%20for%20finding%20matching%20git%20activity%20attributes%22&agg_m=count&agg_m_source=base&agg_t=count&clustering_pattern_field_path=message&cols=host,service&fromUser=true&messageDisplay=inline&storage=hot&stream_sort=desc&viz=stream&from_ts=1738516063536&to_ts=1738775263536&live=true

There are thousands and thousands of error logs with this msg:
You need to use github authored commit activity for finding matching git activity attributes

Issues:

  1. This is being logged for activities where activity type is authored-commit. And this should only be logged for activities that are not authored-commit type.
  2. IMO This should not be an error log, but rather a warn or info
  3. Code uses activity.platform !== PlatformType.GITHUB ||activity.type !== GithubActivityType.AUTHORED_COMMIT to log the error but activity.platform doesn't exist. Should probably be passed in the parameters

But ultimately, if we are no longer using the github archive, why are we still using this function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant