Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community Feedback Needed] Play & Pause icon flipped in simplified theme #30

Open
7HE-W0R1D opened this issue Mar 10, 2024 · 2 comments
Assignees
Labels
design issue Issues with the design decisions made

Comments

@7HE-W0R1D
Copy link

Device: iPod 5th gen 30GB
Rockbox Version: Release 3.15
Adwaitapod Theme: adwaitapod simplified
Downloaded From: Rockbox Utility
Description:
When playing the music, the triangle "Play" icon is displayed. And when the music is paused, the double vertical dash "Pause" icons is displayed. This is the opposite behaviour as the other music players (rhythmbox, monophony, etc,), where the Play icon is displayed when music is paused, not playing.

@7HE-W0R1D 7HE-W0R1D added the bug Something isn't working label Mar 10, 2024
@D0-0K
Copy link
Owner

D0-0K commented Mar 11, 2024

Hi there! This is actually intended behaviour as the play & pause icons serve as indicators of the player status rather than buttons. It's more mimicry than actual function in adwaitapod, hence the visual behaviour is the reverse of traditional GUI music players.

I do agree though that this is confusing, I'm not sure if such a major change would be possible though, so I'd like to leave this open and see if other people have opinions on this.

@D0-0K D0-0K added design issue Issues with the design decisions made and removed bug Something isn't working labels Mar 11, 2024
@D0-0K D0-0K changed the title Play & Pause icon flipped in simplified theme [Community Feedback Needed] Play & Pause icon flipped in simplified theme Mar 11, 2024
@D0-0K D0-0K self-assigned this Mar 11, 2024
@7HE-W0R1D
Copy link
Author

It's more mimicry than actual function in adwaitapod, hence the visual behaviour is the reverse of traditional GUI music players.

I see :) I tried the adwaitapod non-simplified version and the icons make absolute sense there. They live on the top status bar of the screen, hence serves as the indicator of the current status, like shown in the title image here below.
image

The problem is that in the simplified version the icons are not on the status bar, but on buttons, so they now shows the intended action, not the current status, of the player, which is just the opposite. Like here in the image.
image

It's my first time using a player that comes with a screen, so I could be just so used to the GUI players that I just need to learn :)

But it's a great project! As a fedora user I bought an iPod immediately when I saw this theme 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issue Issues with the design decisions made
Projects
None yet
Development

No branches or pull requests

2 participants