From 4d1836635aa3c0ffcd90060d0d13b94cede071fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Paul=20M=C3=BCller?= <dev@craban.de>
Date: Mon, 22 Apr 2024 23:03:15 +0200
Subject: [PATCH] enh: improve logging in background job

---
 CHANGELOG                | 2 ++
 ckanext/dc_serve/jobs.py | 8 +++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG b/CHANGELOG
index 9196847..9086671 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,5 @@
+0.15.4
+ - enh: improve logging in background job
 0.15.3
  - fix: do not use unreliable tempfile.TemporaryDirectory
  - setup: bump dclab to 0.58.3 (LazyContourList has max_events)
diff --git a/ckanext/dc_serve/jobs.py b/ckanext/dc_serve/jobs.py
index b03f18f..8bb6f0d 100644
--- a/ckanext/dc_serve/jobs.py
+++ b/ckanext/dc_serve/jobs.py
@@ -1,5 +1,7 @@
+import logging
 import pathlib
 import tempfile
+import traceback
 import warnings
 
 import ckan.plugins.toolkit as toolkit
@@ -13,6 +15,9 @@
 from .res_file_lock import CKANResourceFileLock
 
 
+log = logging.getLogger(__name__)
+
+
 def admin_context():
     return {'ignore_auth': True, 'user': 'default'}
 
@@ -20,6 +25,7 @@ def admin_context():
 def generate_condensed_resource_job(resource, override=False):
     """Generates a condensed version of the dataset"""
     rid = resource["id"]
+    log.info(f"Generating condensed resource {rid}")
     wait_for_resource(rid)
     mtype = resource.get('mimetype', '')
     if (mtype in DC_MIME_TYPES
@@ -127,7 +133,7 @@ def generate_condensed_resource_job(resource, override=False):
                                          override=True)
                     return True
         except BaseException:
-            pass
+            log.error(traceback.format_exc())
         finally:
             path_cond.unlink(missing_ok=True)
     return False