New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in Hm0 calculation for spectrum dfsu in some cases #525

Open

jsmariegaard opened this issue Jan 10, 2023 · 1 comment

Labels

bug out of scope

Member

jsmariegaard commented Jan 10, 2023

Two problems have been identified for spectral dfsu files in the Hm0 calculation:

deletevalues in spectrum will give nan Hm0 - it should be safe to treat them as 0
if the file uses radians instead of degrees (unit: meter pow 2 sec per rad), the directional integration is wrong and Hm0 results will be sqrt(180/pi) too large.

Member

ecomodeller commented Sep 21, 2023

No action have been taken on this issue, is this a hint that

mikeio/mikeio/dfsu/_spectral.py

Line 324 in 4929b6f

def calc_Hm0_from_spectrum(

and related functionality is actually out of scope for MIKE IO?

ecomodeller added bug out of scope labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment