From 107c417e32b9f6245a9281ea660c2419b33b9f08 Mon Sep 17 00:00:00 2001 From: Matt Dick Date: Tue, 17 Dec 2024 07:57:24 -0800 Subject: [PATCH] [Bugfix] Delete commas when escaping tag content (#301) --- lib/datadog/statsd/serialization/tag_serializer.rb | 4 ++-- spec/statsd/serialization/tag_serializer_spec.rb | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/datadog/statsd/serialization/tag_serializer.rb b/lib/datadog/statsd/serialization/tag_serializer.rb index 95860df..4a44bb1 100644 --- a/lib/datadog/statsd/serialization/tag_serializer.rb +++ b/lib/datadog/statsd/serialization/tag_serializer.rb @@ -74,8 +74,8 @@ def to_tags_list(tags) def escape_tag_content(tag) tag = tag.to_s - return tag unless tag.include?('|') - tag.delete('|,') + return tag unless tag.include?('|') || tag.include?(',') + tag.delete('|,') end def dd_tags(env = ENV) diff --git a/spec/statsd/serialization/tag_serializer_spec.rb b/spec/statsd/serialization/tag_serializer_spec.rb index d45be5f..32d4246 100644 --- a/spec/statsd/serialization/tag_serializer_spec.rb +++ b/spec/statsd/serialization/tag_serializer_spec.rb @@ -132,6 +132,8 @@ context '[testing serialization edge cases]' do it 'formats tags with reserved characters' do expect(subject.format(['name:foo,bar|foo'])).to eq 'name:foobarfoo' + expect(subject.format(['name:foobar|foo'])).to eq 'name:foobarfoo' + expect(subject.format(['name:foo, bar, and foo'])).to eq 'name:foo bar and foo' end it 'formats tags values with to_s' do