Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Auto-Label Items as Trash #10966

Open
RomaBureacov opened this issue Feb 26, 2025 · 4 comments
Open

Ability to Auto-Label Items as Trash #10966

RomaBureacov opened this issue Feb 26, 2025 · 4 comments

Comments

@RomaBureacov
Copy link

Proposed change

Right now, you have to manually label items as trash. Bungie has yet to implement an auto-dismantling system, so it makes it a bit tedious to sift through loot you pretty much always end up dismantling. Because of this, it is also easy to aimlessly dismantle hoards of loot in the postmaster and never see what the loot contains.

The wishlist feature lets DIM mark items with the perks of interest using a small, blue thumbs up icon. The proposed feature is almost like an "unwishlist" or "non-wishlist," specific traits you do not want on any weapon will be automatically labeled as "trash" by DIM.

There are certain perks that we don't see the reason for on certain weapons.

  • Suppose you have the opinion that Machine Guns that roll Hip-Fire Grip aren't worth keeping around. Thus DIM would catch any incoming machine guns into your inventory and automatically tag them as "trash" should they contain Hip-Fire Grip as one of the column.
  • Suppose you really love the trait Killing Tally for Machine guns.
  • Suppose, again, that you get a machine gun with Hip-Fire Grip and Killing Tally as the only two traits. DIM notices the Hip-Fire Grip and automatically marks it as trash, so even if it went to postmaster and you forgot about it, you know that you can just leave it there and dismantle it later or have it overflowed without consequence.
  • Suppose, however, you get another machine gun, but this time with one column having Overflow and Hip-Fire Grip and the other column having Surrounded. Since there is no opinion on Overflow nor Surrounded, and Hip-Fire Grip may be changed with Overflow, DIM does not mark this item as trash.

This could potentially be extended to armor, where armor having stat rolls under some specified amount will be automatically tagged as trash, or if it does not contain the desired stat spikes it is automatically tagged as trash.

How does this fit into your workflow?

  • Makes it easier to see what needs to be dismantled from a glance rather than having to rely on Wishlists and manual inspection. It would be tedious to make a wishlist for every weapon roll.

  • Makes it easier to see that an armor roll is worth considering or not from a glance.

@bhollis
Copy link
Contributor

bhollis commented Feb 26, 2025

Makes sense. This sounds a lot like the "trash lists" feature that we already support: https://github.com/DestinyItemManager/DIM/wiki/Creating-Wish-Lists

Otherwise I think it's already captured in #7219

@RomaBureacov
Copy link
Author

I see, I've haven't heard of trash lists being added to the wishlist feature.

The only pain is that wishlists still require a specific weapon, in that I wouldn't be able to specify ALL machine guns, only one single specific weapon.

If a new season/episode/event/whatever rolls by and they added a new machine gun, it would be undesirable having to make a new trash list for every machine gun that was added just because my opinion is that I want to have Hip-Fire on machine guns.

It definitely feels like it is mostly captured in #7219, only that it could be abstracted a little bit and look at traits and the general weapon types, instead of specific weapons (i.e. look at traits for anything classified as a fusion rifle, rather than specifically within Techeun Force, or Main Ingredient, or Snorri FR5, or...).

There's also the issue of the note in the wishlists

Note that you cannot combine Trash Lists and the wildcard item ID (-69420).

Meaning that just to create a trash list I have to do it for every single weapon rather than just the general weapon type.

@bhollis
Copy link
Contributor

bhollis commented Feb 26, 2025

Right, improvements to wish lists (and trash lists) are covered in #10313

@Roman-Bureacov
Copy link

Seems like it could just be something implemented on top of improvements to the wishlist feature.

I don't have anything more to comment. Thanks for providing the community with DIM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants