Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.3 小节中给出的最佳实现代码中 is_chief 的赋值位置错误 #2

Closed
Mlearn opened this issue Aug 11, 2018 · 3 comments
Closed

5.3 小节中给出的最佳实现代码中 is_chief 的赋值位置错误 #2

Mlearn opened this issue Aug 11, 2018 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Mlearn
Copy link

Mlearn commented Aug 11, 2018

is_chief = (FLAGS.task_index == 0) 是否应该放在 312 行之前？
@DjangoPeng
Copy link
Owner

谢谢你的建议。如果重印时采纳了你的建议。我们会显式致谢！

@DjangoPeng
Copy link
Owner

刚刚查看了下。这行代码是用来判断当前的 task 是否为 chief task，放在这里没有问题哈。

@DjangoPeng
Copy link
Owner

你指的应该是 5.2节 的最佳实践吧？如果是的话，那个 bug 我刚刚更新了，下次印刷会修复。谢谢你的建议！
Ref: #5

@DjangoPeng DjangoPeng added bug Something isn't working duplicate This issue or pull request already exists labels Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mlearn @DjangoPeng