Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defines the default animation #245

Open
rmakiyama opened this issue Jan 14, 2020 · 6 comments
Open

defines the default animation #245

rmakiyama opened this issue Jan 14, 2020 · 6 comments
Assignees

Comments

@rmakiyama
Copy link
Contributor

rmakiyama commented Jan 14, 2020

Kind (Required)

  • Other

Overview (Required)

  • defines the default animation for navigation component.

https://github.com/DroidKaigi/conference-app-2020/blob/master/corecomponent/androidcomponent/src/main/res/navigation/navigation.xml#L14

@ochim
Copy link
Contributor

ochim commented Jan 16, 2020

I want to contribute.
But I don't understand the aim of this issue.
modify @anim/fade_in and @anim/fade_out ?
add new animation files ?

@takahirom
Copy link
Member

takahirom commented Jan 16, 2020

Thank you for the comment! 👍
We should implement the XML attribute for all actions.
But we don't want to create boilerplate.

app:enterAnim="@anim/fade_in"
            app:exitAnim="@anim/fade_out"
            app:popEnterAnim="@anim/fade_in"
            app:popExitAnim="@anim/fade_out"

https://github.com/DroidKaigi/conference-app-2020/blob/master/corecomponent/androidcomponent/src/main/res/navigation/navigation.xml#L14

So we want to add default animation.

@ochim
Copy link
Contributor

ochim commented Jan 16, 2020

OK, I see.
The boilerplate is wordy.
But I can't find the solution. Sorry

@takahirom
Copy link
Member

takahirom commented Jan 16, 2020

It's ok. me too 😄

@umakoz
Copy link

umakoz commented Jan 17, 2020

I wanna try. 🙋‍♂️

@takahirom
Copy link
Member

Thanks! Assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants