Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove expense #654

Open
Macludde opened this issue Dec 16, 2024 · 0 comments
Open

Add ability to remove expense #654

Macludde opened this issue Dec 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Macludde
Copy link
Contributor

Description

Right now you can only approve, you can't reject or remove bad expenses, you should be able to. It would be nice to be able to view removed expenses (I do not think we need to be able to un-remove expenses).

Describe the solution you'd like

It should not delete any information, instead it should mark it as removed and thus hide it on relevant pages (/expenses and /expenses/all). Add a new tab on /expenses/all ("rejected" or "removed") which shows removed expenses.

Make sure to add a "are you sure" button to expenses. Also, make sure to set the zmodel auth to not allow anyone to delete expenses which have been approved (if so, they should disapprove first)

Describe alternatives you've considered

  • Delete the rows (could lose important data)
  • Let them be (clutters up the frontend)
  • separate /expenses/rejected page (duplicate code)
@Macludde Macludde added the enhancement New feature or request label Dec 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in CPU Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant