From 6b6f3f3912daddea258b19b227eff5eeba510f9e Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Wed, 31 Jan 2024 14:31:40 -0800 Subject: [PATCH 1/2] Add instructions on how to watch for test failures to triage docs And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures. --- api/docs/triager.dox | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/api/docs/triager.dox b/api/docs/triager.dox index 2701d419bd7..36ac62be4e4 100644 --- a/api/docs/triager.dox +++ b/api/docs/triager.dox @@ -36,9 +36,11 @@ We have a rotating Triager who is responsible for monitoring our continuous testing infrastructure and for triaging incoming requests from users. Specific duties include: -- Ensure that our Continuous Integration testing through Github Actions and Jenkins are operating smoothly. +- Ensure that our Continuous Integration testing through Github Actions are operating smoothly. + - Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions. - If flaky tests are failing too often, assign someone to fix them ASAP, or mark them to be ignored in `runsuite_wrapper.pl`. - Watch merges to master for failures on the longer test suite. + - Do this by watching for merges on the dynamorio-devs@ list. - File an issue on previously-unknown failures, or update existing issues for repeats. Consider marking tests as flaky in `runsuite_wrapper.pl` if they are keeping the master merge red. - Answer (or request that someone else who is more of an expert in that area answer) incoming dynamorio-users emails. - Sometimes emails to the list are marked as spam, so it is a good idea to directly watch the web interface: https://groups.google.com/g/DynamoRIO-Users From 8a4f74ae46dc106cd6c3e54ef7d03a0785c3b517 Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Fri, 9 Feb 2024 16:34:08 -0800 Subject: [PATCH 2/2] Update instructions for how to watch merges to master --- api/docs/triager.dox | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/docs/triager.dox b/api/docs/triager.dox index 36ac62be4e4..3cf10bbac46 100644 --- a/api/docs/triager.dox +++ b/api/docs/triager.dox @@ -37,10 +37,10 @@ We have a rotating Triager who is responsible for monitoring our continuous testing infrastructure and for triaging incoming requests from users. Specific duties include: - Ensure that our Continuous Integration testing through Github Actions are operating smoothly. - - Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions. + - Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions. Look for red Xs and in those failing builds watch for flaky tests. - If flaky tests are failing too often, assign someone to fix them ASAP, or mark them to be ignored in `runsuite_wrapper.pl`. - Watch merges to master for failures on the longer test suite. - - Do this by watching for merges on the dynamorio-devs@ list. + - Do this by going to the Github Actions page for the master branch: https://github.com/DynamoRIO/dynamorio/actions?query=branch%3Amaster. Look for red Xs and investigate any failures found. - File an issue on previously-unknown failures, or update existing issues for repeats. Consider marking tests as flaky in `runsuite_wrapper.pl` if they are keeping the master merge red. - Answer (or request that someone else who is more of an expert in that area answer) incoming dynamorio-users emails. - Sometimes emails to the list are marked as spam, so it is a good idea to directly watch the web interface: https://groups.google.com/g/DynamoRIO-Users