Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdomains of a disabled site domain are not reported correctly as disabled in popup #3064

Closed
ghostwords opened this issue Feb 26, 2025 · 1 comment
Closed

Subdomains of a disabled site domain are not reported correctly as disabled in popup #3064

ghostwords opened this issue Feb 26, 2025 · 1 comment
Labels
bug Chrome MV3 Manifest V3-specific issue

Comments

@ghostwords
Copy link
Member

ghostwords commented Feb 26, 2025 •
edited
Loading

To reproduce:

  1. Add example.com to the list on the Disabled Sites options page tab in MV3.
  2. Visit www.example.com.
  3. PB's icon/popup should be shown as disabled but they are shown as active.

In addition:

  • We will incorrectly attempt to insert widget placeholders (even though nothing was actually blocked as DNR is in fact disabled).
  • Google/Facebook link cleaning content scripts will proceed when they shouldn't.
  • Cookie "clobbering" content scripts will proceed when they shouldn't.
  • Local learning content scripts will proceed when they shouldn't.

The problem is that badger.isPrivacyBadgerEnabled() doesn't know that disabled sites always include subdomains in MV3 (#3061).
@ghostwords ghostwords added bug Chrome MV3 Manifest V3-specific issue labels Feb 26, 2025
@ghostwords
Copy link
Member Author

Fixed by 06d3e35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Chrome MV3 Manifest V3-specific issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ghostwords