-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future Hand Prediction: Is the mask multiplied by the prediction we submit? #19
Comments
hi @masashi-hatano happy to have you as our participant! |
@VJWQ But, I don't really understand why num_clips is needed. According to the sample evaluation code, num_clips is used just for dividing the predicted values. I would appreciate if you could give me some explanation about it. |
Sure, please refer to the explanation. the number 30 is obtained from the line |
@VJWQ |
@masashi-hatano for key in pred_dict:
pred_dict[key] = pred_dict[key] / num_clips after the multi-view accumulation. |
@takfate |
@masashi-hatano |
hi @takfate, your results will not be divided twice. In |
If so, it's fine for me, thanks though. |
@VJWQ @masashi-hatano |
I tried submitting a json file, which follows the specified format, and I obtained the quantitative result as follows.
However, even though the results that we tested in the validation dataset were better than the baseline, the results obtained from the actual submissions have a huge amount of errors.
This is probably because the mask is not multiplied by the prediction we submit. The mask is used so that the error is zero on frames in which hand is not visible.
To demonstrate that the quantitative results presented above are anomalous, here are a prediction list, which is a part of my submission.json file, and its visualization result.
As you can see these figures, the quantitative results obtained from the actual submission seem to be incorrect, and the reason for this is thought to be that the loss is calculated without multiplying the predictions by the masks.
@VJWQ
Could you please confirm that the loss calculation is done correctly? In particular, I would appreciate it if you could check if the process is done to set the error to zero if the hands are not in frames.
Figure1 pre_45 frame
Figure2 pre_30 frame
Figure3 pre_15 frame
Figure4 pre_frame
Figure5 contact_frame
The text was updated successfully, but these errors were encountered: