Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflookall incomplete when using external Lua #10

Open
ahkole opened this issue Apr 20, 2023 · 3 comments
Open

libflookall incomplete when using external Lua #10

ahkole opened this issue Apr 20, 2023 · 3 comments

Comments

@ahkole
Copy link

ahkole commented Apr 20, 2023

The all-in-one library libflookall.a is currently incomplete when using an external Lua installation by setting LUA_DIR. The liball target in the root Makefile still tries to use ../aotus/obj/external/lua-5.3.5/src/liblua.a (hardcoded) even though that isn't available when using an external Lua. You probably want to conditionally set the Lua library to include in libflookall.a based on the value of LUA_DIR similarly as is done for the variable LUA__LIB in aotus/Makefile.smeka:

ifdef LUA_DIR
 # User-defined
 INCLUDES += -I$(LUA_DIR)/include
 LUA__LIB = $(LUA_DIR)/lib/liblua.a
lua-lib:
        @echo ""
        @echo "Adding external Lua library to lib$(AOTUS_LIB).*"
        @echo "Extracting $(LUA_DIR)/lib/liblua.a"
        @echo ""
        $(AR) -x $(LUA__LIB)

else

 # lua-sources shipped
 LUA_DIR = external/lua-$(EXTERNAL_LUA_V)
 INCLUDES += -I$(LUA_DIR)/src
 LUA__LIB = $(LUA_DIR)/src/liblua.a
lua-lib:
        mkdir -p external
        cp -rf $(TOP_DIR)/$(LUA_DIR) external/
        $(MAKE) -C $(LUA_DIR) $(PLATFORM)
        $(AR) -x $(LUA__LIB)
@ahkole
Copy link
Author

ahkole commented Apr 24, 2023

@zerothi Are you the maintainer of this project?

@zerothi
Copy link
Contributor

zerothi commented Apr 24, 2023

Yes I am, haven't had the time to look into this.

@ahkole
Copy link
Author

ahkole commented Apr 24, 2023

Okay, no worries there is no rush. Just wanted to check if anyone was still watching this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants