Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Microsoft.Data.SqlClient instead of System.Data.SqlClient in MsSqlDataConnection #528

Open
MaximBalaganskiy opened this issue Dec 14, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@MaximBalaganskiy
Copy link

Is your feature request related to a problem? Please describe.
Azure Managed Identity connection strings are not supported in System.Data.SqlClient.SqlConnection

Describe the solution you'd like
Return Microsoft.Data.SqlClient.SqlConnection from GetConnectionType

Describe alternatives you've considered
The alternative is to create a custom FR connection

Additional context
See https://devblogs.microsoft.com/dotnet/introducing-the-new-microsoftdatasqlclient/

@MaximBalaganskiy MaximBalaganskiy added the enhancement New feature or request label Dec 14, 2022
@KirillKornienko KirillKornienko self-assigned this Dec 15, 2022
@KirillKornienko
Copy link
Contributor

KirillKornienko commented Dec 15, 2022

Thanks for the idea. Is the new SqlClient fully compatible with the old SqlClient? I think we need to add new plugin with other name for minimize user's errors but I have no idea what the new plugin will be called and maybe we really need to replace it.

@MaximBalaganskiy
Copy link
Author

It is compatible. Plus it supports more connection string formats

@rafaelchei
Copy link

Like @MaximBalaganskiy said, it is compatible but I just want to point out that Microsoft.Data.SqlClient has a breaking change, the Encryption is now On by Default.
I guess this is just one more reason to add a new plugin instead of using the current one.

See here: https://weblog.west-wind.com/posts/2021/Dec/07/Connection-Failures-with-MicrosoftDataSqlClient-4-and-later#encryption-is-now-on-by-default

@BogdanStegachev
Copy link

Hello!

Microsoft.Data.SqlClient instead of System.Data.SqlClient is planned in the next release, expect changes

Best regards,
Bogdan

@MaximBalaganskiy
Copy link
Author

Any progress on this?

@MaximBalaganskiy
Copy link
Author

MaximBalaganskiy commented Feb 16, 2025

@BogdanStegachev Please reopen, this is not resolved

@BogdanStegachev
Copy link

Hello!

At the moment the replacement of Microsoft.Data.SqlClient instead of System.Data.SqlClient is not completed, as soon as there are changes we will immediately inform you in this issue

Best regards,
Bogdan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants