Declare package exports in the actual package instead of the parent. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@konstantinblaesi thank you so much for putting that mich effort in it! I think the comment above is still relavant 🤔 @davideast would you mind to have a look at it? It would solve 3-4 issues as far as I see 🙏 |
|
setting type = module on the parent package.json also seems to fix the issue, would that be preferred to this PR? |
simpros
approved these changes
Dec 22, 2022
ErikSandquist
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I am not using the library or have good knowledge on the exports topic but on taking a closer look it seemed like the exports as shown in the PR make more sense.
I made a SvelteKit repo that can demonstrate the runtime issue due to bad exports . I only used npm link to confirm that those changes resolved my error.
Do these make sense or would it break something else?
Fixes #52