Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Annotations in generated code #1

Closed
ZacSweers opened this issue Sep 1, 2015 · 3 comments
Closed

Support Annotations in generated code #1

ZacSweers opened this issue Sep 1, 2015 · 3 comments
Assignees
@ZacSweers
Labels
enhancement

Comments

@ZacSweers
Copy link
Contributor

Hacked at this for awhile and can't for the life of me get it to work.

Adding a dependency with a local maven URL (as per the docs' suggestion) doesn't work because it still can't find it.

Adding the jar works, but doesn't get included in the packaging for some reason.

If we do add this though, we would want the following:

  • All put() methods would have @CheckResult and @NonNull annotations
  • All rx() methods would have @CheckResult and @NonNull annotations
  • All put(String) methods would have @Nullable annotations on the parameter
    • This applies to future object types too
@ZacSweers
Copy link
Contributor Author

Possibly related issue: JakeWharton/butterknife#362

@ZacSweers ZacSweers self-assigned this May 7, 2016
@ZacSweers
Copy link
Contributor Author

I know how to do this now, will work on it when I'm back from vacation

@ZacSweers ZacSweers mentioned this issue May 14, 2017
Closed
@ZacSweers
Copy link
Contributor Author

This issue was moved to ZacSweers#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZacSweers ZacSweers

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZacSweers